Fixed #452 #454
Merged
Fixed #452 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 21, 2020
resources/assets/js/jsvalidation.js
Outdated
| validator.showErrors(); | ||
| } else { | ||
| var errors = {}; | ||
| errors[element.name] = previous.message = $.isFunction(message) ? message(value) : message; |
| if (laravelValidation.methods[rule] !== undefined) { | ||
| $.each(values, function(index, value) { | ||
| validated = laravelValidation.methods[rule].call(validator, value, element, param[1], function(valid) { | ||
| validator.settings.messages[element.name].laravelValidationRemote = previous.originalMessage; |
| validator.showErrors( errors ); | ||
| if (laravelValidation.methods[rule] !== undefined) { | ||
| $.each(values, function(index, value) { | ||
| validated = laravelValidation.methods[rule].call(validator, value, element, param[1], function(valid) { |
| if ( !implicit && validator.optional( element ) ) { | ||
| validated="dependency-mismatch"; | ||
| if (! implicit && validator.optional(element)) { | ||
| validated = "dependency-mismatch"; |
| $.each(rules, function (i, param) { | ||
| var implicit = param[3] || laravelValidation.implicitRules.indexOf(param[0])!== -1; | ||
| var implicit = param[3] || laravelValidation.implicitRules.indexOf(param[0]) !== -1; |
|
If you use Ideally need to split it so rules without |
houndci-bot
reviewed
Jun 22, 2020
| if (param[3] || laravelValidation.implicitRules.indexOf(param[0]) !== -1) { | ||
| isArrayRule ? arrayRules.unshift(param) : rules.unshift(param); | ||
| } else { | ||
| isArrayRule ? arrayRules.push(param) : rules.push(param); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| // put Implicit rules in front | ||
| var isArrayRule = param[4].indexOf('[') !== -1; | ||
| if (param[3] || laravelValidation.implicitRules.indexOf(param[0]) !== -1) { | ||
| isArrayRule ? arrayRules.unshift(param) : rules.unshift(param); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| $.each(params, function (i, param) { | ||
| // put Implicit rules in front | ||
| var isArrayRule = param[4].indexOf('[') !== -1; | ||
| if (param[3] || laravelValidation.implicitRules.indexOf(param[0]) !== -1) { |
| * Create JQueryValidation check to validate Laravel rules. | ||
| */ | ||
|
|
||
| $.validator.addMethod("laravelValidation", function (value, element, params) { |
| if (name in cache[element.name]) { | ||
| $.extend(rules, cache[element.name][name]); | ||
| rules = laravelValidation.helpers.mergeRules(rules, cache[element.name][name]); |
| continue; | ||
| } | ||
|
|
||
| if (typeof rules[key] === "undefined") { |
| 'laravelValidationRemote': newRules.laravelValidationRemote || [] | ||
| }; | ||
|
|
||
| for (var key in rulesList) { |
There was a problem hiding this comment.
The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.
This was
linked to
issues
Jun 22, 2020
Closed
houndci-bot
reviewed
Jun 23, 2020
| var errors = {}; | ||
| errors[ element.name ] | ||
| = previous.message | ||
| = typeof message === "function" ? message( value ) : message; |
There was a problem hiding this comment.
Line is too long.
Misleading line break before '='; readers may interpret this as an expression boundary.
Mixed double and single quotes.
| } else { | ||
| var errors = {}; | ||
| errors[ element.name ] | ||
| = previous.message |
There was a problem hiding this comment.
Misleading line break before '='; readers may interpret this as an expression boundary.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
$.eachon array inputs. Array inputs are only returned on select-multiple elements.This fix somewhat clashes with #453
In the case of
['domain' => 'array', 'domain.*' => 'max:2']arrayRulesoverwrites the'domain'rules.