Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page "Complete command reference" broken #39

Closed
misaflo opened this issue Jan 14, 2020 · 5 comments
Closed

Page "Complete command reference" broken #39

misaflo opened this issue Jan 14, 2020 · 5 comments
Assignees
Labels

Comments

@misaflo
Copy link

misaflo commented Jan 14, 2020

Hello,

The page Complete command reference is broken.
It must be since the removing of jquery (the page still use jquery).

@jubalh
Copy link
Member

jubalh commented Jan 14, 2020

Thanks for the report.
I saw so too this morning.

Didn't have time to fix it yet.

If you want you could give it a try and create a PR! :)

@jubalh
Copy link
Member

jubalh commented Jan 14, 2020

Or @MattyBalaam could take a look? Seems like the last PR caused this.

@jubalh jubalh added the bug label Jan 14, 2020
@MattyBalaam
Copy link
Contributor

Sorry I missed that.

Looks like a strange use of using jQuery to me for it to load partial content in that way ;)

I wonder if instead of re-inventing the wheel for the wrong purpose it might be better to use some kind of build step to include partials like this?

@MattyBalaam
Copy link
Contributor

Quick solution would be just to include jquery on this page only, possibly from a CDN.

jubalh added a commit that referenced this issue Jan 14, 2020
@jubalh jubalh closed this as completed Jan 14, 2020
@jubalh jubalh self-assigned this Jan 14, 2020
@jubalh
Copy link
Member

jubalh commented Jan 14, 2020

Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants