Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts are marked offline despite being online #1050

Closed
pmaziere opened this issue Apr 11, 2019 · 7 comments · Fixed by #1063
Closed

Contacts are marked offline despite being online #1050

pmaziere opened this issue Apr 11, 2019 · 7 comments · Fixed by #1063
Labels
bug
Milestone
0.7.0

Comments

@pmaziere
Copy link
Contributor

Everything was fine with 0.6.0 from debian testing

I removed the debian package, compiled and installed 61df0c8 with OMEMO support to test it.

Now, after connection, contacts are marked offline despite being online as shown by another xmpp client (conversations).
Some of them are set online when they start chatting, while others stay offline despite being engaged in a chat.
All chats are OMEMO enabled.

I could not find a way to log debugging information, so if you need more, I'll be glad to help given that you provide me with a mean to do so :)

Thanks for this long awaited OMEMO enabled profanity !
@paulfariello
Copy link
Contributor

Hi,

Can you dump us logs with profanity --log=DEBUG.
Logs can be found in .local/share/profanity/logs/profanity.log.

@jubalh
Copy link
Member

jubalh commented Apr 11, 2019

Thanks for your report @pmaziere !

Details about debug info should be at http://profanity.im/issues.html

How does Conversations actually show whether a contact is online/offline? Greying out avatars?

@jubalh jubalh added the OMEMO label Apr 11, 2019
@jubalh jubalh added this to the 0.7.0 milestone Apr 11, 2019
@pmaziere
Copy link
Contributor Author

pmaziere commented Apr 11, 2019 •
edited

@jubalh Conversations has an option to enable in order to change the color of the "send msg" arrow according to the contact status

@paulfariello here is the log redacted for privacy: let's hope I did not miss anything :)
user1 is never shown online, while user2 appears offline when profanity is connected, then online after sending its first message.
All other users are shown offline while they are actually online.

@paulfariello
Copy link
Contributor

Thanks @pmaziere for the logs.

Seems like roster is received (line 123) right after presences (last one is at line 108). In such conditions profanity won't update roster in UI.

@jubalh any idea on how it could be fixed? Storing presence until we get roster could be a way.

PS: @pmaziere you might want to delete your logs now. We have a pretty clear view of what's happening and there is the sasl exchange in the log and you account name ;)

@pmaziere
Copy link
Contributor Author

pmaziere commented Apr 12, 2019 •
edited

@paulfariello I did delete the link in the comment, but how do I delete the file uploaded to github ?
my account name without a server address is kind of no use, isn't it ?

@jubalh jubalh added bug and removed OMEMO labels Apr 12, 2019
@paulfariello paulfariello mentioned this issue Apr 16, 2019
Merged
paulfariello added a commit to paulfariello/profanity that referenced this issue Apr 17, 2019
@paulfariello
Handle presence received before roster
be61a30 
Presence of contact not found in roster are filtered out.
But sometimes roster is received after a first few presences.

We choose to store presences until we receive roster and then process
this presences.

Fixes profanity-im#1050
paulfariello added a commit to paulfariello/profanity that referenced this issue Apr 17, 2019
@paulfariello
Handle presence received before roster
448e868 
Presence of contact not found in roster are filtered out.
But sometimes roster is received after a first few presences.

We choose to store presences until we receive roster and then process
this presences.

Fixes profanity-im#1050
paulfariello added a commit to paulfariello/profanity that referenced this issue Apr 17, 2019
@paulfariello
Handle presence received before roster
973a05d 
Presence of contact not found in roster are filtered out.
But sometimes roster is received after a first few presences.

We choose to store presences until we receive roster and then process
this presences.

Fixes profanity-im#1050
@kaffeekanne
Copy link
Contributor

#1063 fixes falsely offline roster entries for me.

@pmaziere
Copy link
Contributor Author

It works fine here too
thanks !

jubalh added a commit that referenced this issue Jun 2, 2020
@jubalh
Fix offline roster contacts
3d7a313 
Fix #1280
p_contact_set_presence() is triggered in
(roster_process_pending_presence) to set the presence to online
after the roster is displayed.

This happened to me _every time_ with one certain account on my server.
But not even once with other accounts on my server.

I don't understand why that is the case, but AFAIK the code should be
like it is in this PR anyways.

roster_process_pending_presence() was added there in
973a05d to fix
#1050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Handle presence received before roster paulfariello/profanity
4 participants
@paulfariello @pmaziere @jubalh @kaffeekanne