Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMEMO: Autocomplete suggests fingerprints not belonging to the selected contact #1068

Closed
philipflohr opened this issue Apr 17, 2019 · 6 comments
Assignees
Milestone

Comments

@philipflohr
Copy link
Contributor

The OMEMO autocomplete feature suggests fingerprints not belonging to the selected contact.

Steps to reproduce:

  1. Enable omemo (set policy to automatic / always - not tested if this is needed to reproduce...)
  2. Show the fingerprint list of one of your contacts
  3. Write /omemo trust <contact> and use tab for autocompletion
    -> Many fingerprints are suggested, not only the ones belonging to the contact
@jubalh
Copy link
Member

jubalh commented Apr 17, 2019

Yes so far it's all the fingerprints we get.

@jubalh jubalh added this to the 0.7.0 milestone Apr 17, 2019
@jubalh jubalh mentioned this issue Apr 17, 2019
11 tasks
@paulfariello
Copy link
Contributor

AFAICT we don't have access to the first argument of a command from the autocompletion command.
So I can't filter out fingerprints easily.
@pasis, @boothj5 can you confirm?

@jubalh
Copy link
Member

jubalh commented Jun 4, 2019

If we don't solve this (ever or for 0.7.0) then we should document the usage at https://profanity-im.github.io/omemo.html

Maybe also mentioning that people should enable carbons (or auto enabling them for 0.7.0 since I think that most people want them and only some prefer to disable them). And describing that they need to trust their own keys of other devices.

Mentioning that file transfer is not encrypted since its another XEP too.

So that they know how to use OMEMO properly with Profanity and what works and what doesn'.

jubalh added a commit to profanity-im/profanity-im.github.io that referenced this issue Jun 6, 2019
profanity-im/profanity#1068 mentions that
fingerprints autocomplete for every contact.
Since we didn't solve this yet we should document it.

On profanity-im/profanity#1068 I also
mentioned some other things that should be documented which I attempt to
do here.
jubalh added a commit to profanity-im/profanity-im.github.io that referenced this issue Jun 6, 2019
profanity-im/profanity#1068 mentions that
fingerprints autocomplete for every contact.
Since we didn't solve this yet we should document it.

On profanity-im/profanity#1068 I also
mentioned some other things that should be documented which I attempt to
do here.
@jubalh
Copy link
Member

jubalh commented Jun 6, 2019

I documented this on the website now. We will release 0.7.0 as it is and hope users read the documentation.

Planning to tackle this for 0.8.0.

@jubalh jubalh modified the milestones: 0.7.0, 0.8.0 Jun 6, 2019
@jubalh
Copy link
Member

jubalh commented Nov 13, 2019

AFAICT we don't have access to the first argument of a command from the autocompletion command.
So I can't filter out fingerprints easily.

@paulfariello We could create a new function. Autocomplete still has it in the input argument.

@paulfariello
Copy link
Contributor

We should merge all omemo autocomplete functions into a single one in order to filter the fingerprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants