Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: manage bookmarks also locally #1115

Closed
kaffeekanne opened this issue Jun 5, 2019 · 7 comments
Closed

Feature request: manage bookmarks also locally #1115

kaffeekanne opened this issue Jun 5, 2019 · 7 comments
Assignees
Milestone

Comments

@kaffeekanne
Copy link
Contributor

Right now profanity respects bookmarks and their set auto-join flag. Using different clients that can be annoying since you might not want all your MUCs autojoind at home, at work or on mobile phone. Therefore other clients offer possibilities of local bookmarkmanagement. What should be done can be discussed here.

  • bookmarks that are on the server should be available and autojoined if set
  • i still would like to (un)set autojoin on server bookmark
  • but also indivually on client side (so others are not affected)

Further ideas or approaches?

@jubalh jubalh added this to the 0.8.0 milestone Jun 5, 2019
@pasis
Copy link
Member

pasis commented Jun 5, 2019

For me it looks like a reasonable feature. Technically, it should be hard to implement and the question is how it will look for users. Personally I see two options: extend existing /bookmark command or add new command and call these local bookmarks as a separated entity. Both options have cons and pros.

@kaffeekanne
Copy link
Contributor Author

I like the way gajim does it. If we keep information locally, that is contradictory to xmpp with its servera itself.

@ccxcz
Copy link

ccxcz commented Jun 7, 2019

I think the most straightforward approach here is to have a per-account flag telling us whether to honour the auto-join flag on bookmarks or not, like Conversation does. If disabled one could use e.g. post-connect script to auto-join whichever MUCs and open direct chat windows in order they prefer.

@jubalh jubalh modified the milestones: 0.8.0, 0.9.0 Dec 1, 2019
@jubalh
Copy link
Member

jubalh commented May 22, 2020

I like the way gajim does it. If we keep information locally, that is contradictory to xmpp with its servera itself.

And how does Gajim do it?

@jubalh
Copy link
Member

jubalh commented May 24, 2020

Seems this is currently discussed here https://mail.jabber.org/pipermail/standards/2020-May/037452.html

@jubalh jubalh self-assigned this May 24, 2020
jubalh added a commit that referenced this issue May 24, 2020
```
~/.local/share/profanity % cat bookmark_ignore
[ignore]
profanity@rooms.dismail.de=
```

Regards #1115
jubalh added a commit that referenced this issue May 24, 2020
```
cat ~/.local/share/profanity/bookmark_ignore
[jubalh@iodoru.org]
profanity@rooms.dismail.de=true

[testuser@domain.org]
testr@rooms.domain.org=true
```

Regards #1115
@jubalh
Copy link
Member

jubalh commented May 24, 2020

Commands will follow. For now you can do:

cat ~/.local/share/profanity/bookmark_ignore
[jubalh@domain.org]
profanity@rooms.dismail.de=true

[testuser@domain.org]
testr@rooms.domain.org=true

jubalh added a commit that referenced this issue May 24, 2020
`/bookmarl ignore` lists the ignored bookmarks.

Regards #1115
jubalh added a commit that referenced this issue May 24, 2020
jubalh added a commit that referenced this issue May 24, 2020
@jubalh
Copy link
Member

jubalh commented May 24, 2020

/bookmark ignore
/bookmark ignore add profanity@rooms.dismail.de
/bookmark ignore remove profanity@rooms.dismail.de

@jubalh jubalh closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants