Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save preferences only when explicitly asked to #1164

Closed
jubalh opened this issue Aug 1, 2019 · 2 comments
Closed

Save preferences only when explicitly asked to #1164

jubalh opened this issue Aug 1, 2019 · 2 comments
Assignees
Labels
behaviour-change changes to current behaviour improvement
Milestone

Comments

@jubalh
Copy link
Member

jubalh commented Aug 1, 2019

Currently profanity saves the preferences whenever you change them.
For example /roster resource char X will change it to X and save it to your profrc file.

I think it would make sense to only change it. And have a separate command /save for saving the currently set preferences. Then users could experiment with various settings but revert back easily (by quitting without saving), without first backing up their configuration file.

@jubalh jubalh added this to the 0.8.0 milestone Aug 1, 2019
@jubalh jubalh added the behaviour-change changes to current behaviour label Aug 1, 2019
@kaffeekanne
Copy link
Contributor

I like my settings being stored immediatly, althoug i understand your thoughts. I would forget to save/commit my changes or even not notice i changed something and wonder why profanity acts differently the next time i start it.

What do you think about profiles? If one wants to test some changes, create another profile switch to it and test. Or save the current state in another profile and test in the main profile.

@jubalh jubalh removed the discussion label Aug 2, 2019
@jubalh
Copy link
Member Author

jubalh commented Aug 2, 2019

I think most applications have a 'apply changes/settings' button.

@jubalh jubalh self-assigned this Aug 2, 2019
jubalh added a commit that referenced this issue Aug 2, 2019
Most applications have an 'apply changes' button. This makes testing
easier too.

Implement #1164
@jubalh jubalh closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviour-change changes to current behaviour improvement
Projects
None yet
Development

No branches or pull requests

2 participants