Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /info a bit more user friendly #1194

Closed
mdosch opened this issue Sep 20, 2019 · 3 comments
Closed

Make /info a bit more user friendly #1194

mdosch opened this issue Sep 20, 2019 · 3 comments
Assignees
Milestone

Comments

@mdosch
Copy link
Contributor

mdosch commented Sep 20, 2019

If you use /info contact while you're in a chat window with "contact" profanity doesn't show the info but only tells you that it's not necessary to specify the contact.

Expected Behavior

Show you the info anyway but additionally inform that it's not necessary to specify the contact.

Current Behavior

Profanity doesn't show the info but only tells you that it's not necessary to specify the contact.

Steps to Reproduce (for bugs)

  1. /msg contact
  2. /info contact
  3. Profanity shows only No parameter required when in chat
  4. /info
  5. The info is shown

Environment

Debian Testing

profanity --version
Profanity, version 0.7.0dev.master.fd161d92
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.13.1-unknown)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (2.7.16+)
GTK icons: Enabled
@jubalh jubalh self-assigned this Sep 21, 2019
@jubalh jubalh added this to the 0.8.0 milestone Sep 21, 2019
@mdosch
Copy link
Contributor Author

mdosch commented Sep 24, 2019

The behavior for /status is the same.

@jubalh
Copy link
Member

jubalh commented Sep 24, 2019

I'm not sure what's the best expected behaviour.
It could be that the user types /info someotheruser which is not the one he has in the active chat window.
So I think the correct behaviour would be: use the second parameter always if specified. If not use the nick of the active window when in a chat. And never notify about additional parameter. The only thing is that the output will then only be in console window.

@mdosch
Copy link
Contributor Author

mdosch commented Sep 25, 2019

I guess that would be a good solution.

jubalh added a commit that referenced this issue Sep 29, 2019
jubalh added a commit that referenced this issue Sep 29, 2019
If we pass a jid/nick to `/info` in a chat window we will still get the
output. But on the console window.

Regards #1194
@jubalh jubalh closed this as completed Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants