Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show focused window number in statusbar #1283

Closed
Ppjet6 opened this issue Mar 24, 2020 · 6 comments · Fixed by #1912
Closed

Always show focused window number in statusbar #1283

Ppjet6 opened this issue Mar 24, 2020 · 6 comments · Fixed by #1912
Labels
improvement

Comments

@Ppjet6
Copy link

Ppjet6 commented Mar 24, 2020

Profanity version: 3c56b28
libstrophe: strophe/libstrophe@c92fc84

Expected Behavior

Show the number of the focused window always, even if > 10.

Current Behavior

Only numbers from 1 to 10 (0) are displayed in the statusbar.

Possible Solution

Either display the number always alongside other numbers, or alongside the room name maybe (sounds even better).
@jubalh jubalh added this to the 0.9.0 milestone Mar 24, 2020
@jubalh
Copy link
Member

jubalh commented Mar 24, 2020

"focused"? I understand it right what you want is: show all windows in the statusbar. Not just 1 - (max) 10.

@Ppjet6
Copy link
Author

Ppjet6 commented Mar 25, 2020

When I move to Win 42, I want 42 to be displayed in the numbers below as "the window I'm currently in". I assume we're on the same page, I just wasn't sure with the "all windows" you mentioned.

@jubalh jubalh modified the milestones: 0.9.0, 0.10.0 Jun 3, 2020
@kaffeekanne
Copy link
Contributor

Maybe something like [1][2][3][…][42] in the statusline with max visible windows set to 5.

@jubalh
Copy link
Member

jubalh commented Dec 9, 2020

And 42 would be the active window in this case or the last one?

@janteau
Copy link

janteau commented Dec 9, 2020

Maybe something like [1][2][3][…][42] in the statusline with max visible windows set to 5.

And 42 would be the active window in this case or the last one?

I think it would be nice to show the current window and the max window count. Possibly something like: [1][2][3][…][36][…][42] where 36 is the currently open window and 42 is the last window.

@kaffeekanne
Copy link
Contributor

My example was not thought through very well. @janteau did it much better. Also the active window usually has a highlighted color. But i think you get the idea.

@jubalh jubalh removed this from the 0.10.0 milestone Jan 9, 2021
@H3rnand3zzz H3rnand3zzz mentioned this issue Apr 12, 2023
Closed
@H3rnand3zzz H3rnand3zzz mentioned this issue Nov 6, 2023
Merged
1 task
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 8, 2023
@H3rnand3zzz
Add dynamic paging to statusbar
58a59b4 
Current paging only shows up to `maxtabs` pages starting from console (1),
no matter the current page (tab). It does not allow to see pages near
which can be useful if tab names (`/statusbar show names`) are displayed.

It can be as well useful to know which exact window number is open and
how much more windows are there, at least in the displayed tabs range.

It can be as well useful to know messages that are
left to current position (and even out of display range)
e.g. that you got a message on tab 10, while you are on tab 11 or even 25.

Significantly improve navigation by
making statusbar paging follow current page and display pages/tabs near.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 8, 2023
@H3rnand3zzz
Add dynamic paging to statusbar
f5a33f4 
Current paging only shows up to `maxtabs` pages starting from console (1),
no matter the current page (tab). It does not allow to see pages near
which can be useful if tab names (`/statusbar show names`) are displayed.

It can be as well useful to know which exact window number is open and
how much more windows are there, at least in the displayed tabs range.

It can be as well useful to know messages that are
left to current position (and even out of display range)
e.g. that you got a message on tab 10, while you are on tab 11 or even 25.

Significantly improve navigation by
making statusbar paging follow current page and display pages/tabs near.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 15, 2023
@H3rnand3zzz
Add dynamic paging to statusbar
7e12c46 
Current paging only shows up to `maxtabs` pages starting from console (1),
no matter the current page (tab). It does not allow to see pages near
which can be useful if tab names (`/statusbar show names`) are displayed.

It can be as well useful to know which exact window number is open and
how much more windows are there, at least in the displayed tabs range.

It can be as well useful to know messages that are
left to current position (and even out of display range)
e.g. that you got a message on tab 10, while you are on tab 11 or even 25.

Significantly improve navigation by
making statusbar paging follow current page and display pages/tabs near.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 15, 2023
@H3rnand3zzz
Add dynamic paging to statusbar
6172fef 
Current paging only shows up to `maxtabs` pages starting from console (1),
no matter the current page (tab). It does not allow to see pages near
which can be useful if tab names (`/statusbar show names`) are displayed.

It can be as well useful to know which exact window number is open and
how much more windows are there, at least in the displayed tabs range.

It can be as well useful to know messages that are
left to current position (and even out of display range)
e.g. that you got a message on tab 10, while you are on tab 11 or even 25.

Significantly improve navigation by
making statusbar paging follow current page and display pages/tabs near.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 16, 2023
@H3rnand3zzz
Fix paging in statusbar
ed50f30 
This commit changes the current behaviour which displays always the first
tabs until `maxtabs` to display N tabs around the currently selected tab.

So if we are having a maxtab of 1 and the actively selected window is 2,
then 2 is displayed only.

So far we have only displayed `>` to indicate that there are more windows.
Since this PR shifts the range of tabs that are displayed we also add `<`
indicator now to indicate windows to the left of the currently displayed.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 20, 2023
@H3rnand3zzz
Fix pagination in statusbar
619309a 
This commit changes the current behaviour which displays always the first
tabs until `maxtabs` to display N tabs around the currently selected tab.

So if we are having a maxtab of 1 and the actively selected window is 2,
then 2 is displayed only.

So far we have only displayed `>` to indicate that there are more windows.
Since this PR shifts the range of tabs that are displayed we also add `<`
indicator now to indicate windows to the left of the currently displayed.

Fix profanity-im#1283
Fix profanity-im#1764
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Dec 28, 2023
@H3rnand3zzz
Fix pagination in statusbar
b3c9aa4 
This commit changes the current behaviour which displays always the first
tabs until `maxtabs` to display N tabs around the currently selected tab.

So if we are having a maxtab of 1 and the actively selected window is 2,
then 2 is displayed only.

So far we have only displayed `>` to indicate that there are more windows.
Since this PR shifts the range of tabs that are displayed we also add `<`
indicator now to indicate windows to the left of the currently displayed.

Fix profanity-im#1283
Fix profanity-im#1764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new mode for statusbar tab behaviour H3rnand3zzz/profanity
4 participants
@Ppjet6 @jubalh @kaffeekanne @janteau