Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room configuration only works when the room is rejoined #1347

Closed
ghost opened this issue May 27, 2020 · 0 comments
Closed

room configuration only works when the room is rejoined #1347

ghost opened this issue May 27, 2020 · 0 comments
Labels
improvement
Milestone
0.13.0

Comments

@ghost
Copy link

ghost commented May 27, 2020

Expected Behavior

  • changes to the configration of a MUC should be immediatly applied.

Current Behavior

  • for instance, when i want to configure a room to use OMEMO, i reiceive the error message MUC must be non-anonymous (i.e. be configured to present real jid to anyone) and members-only in order support OMEMO. after the first /omemo start. But after updated the settings as desired, i still receive the same error message altough i have both the real JID presented to anyone, and the MUC is members-only.
  • it is not obvious that one has to leave and join the groupchat for the configuration to be applied.

Possible Solution

  • at least this would have to be documented in the omemo settings.
  • but even better would be to do the correct thing automatically and reload the configuration.

Environment

Profanity, version 0.8.1dev.master.9c853d9f
XMPP library: libmesode
Desktop notification support: Disabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.13.1)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons: Disabled
  • OpenBSD 6.7
  • glib version: 2.64.3
@jubalh jubalh mentioned this issue May 23, 2022
Merged
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue May 27, 2022
@MarcoPolo-PasTonMolo
Make muc config update after form submit
98b7f13 
Muc configuration in profanity used to not update until next login, ie:
make muc non_anonymous and members_only but be unable to start omemo
until next login. Now a disco info request is sent after forrm submit
and chatroom details are changed accordingly.

Fixes profanity-im#1347
@jubalh jubalh added this to the 0.13.0 milestone May 27, 2022
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue May 27, 2022
@MarcoPolo-PasTonMolo
Make muc config update after form submit
3a0c95f 
Muc configuration in profanity used to not update until next login, ie:
make muc non_anonymous and members_only but be unable to start omemo
until next login. Now a disco info request is sent after forrm submit
and chatroom details are changed accordingly.

Fixes profanity-im#1347
@jubalh jubalh closed this as completed in 4839093 May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
1 participant
@jubalh