Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sendfile command encrypts files for regular MUC #1449

Closed
wstrm opened this issue Dec 9, 2020 · 0 comments · Fixed by #1450
Closed

Sendfile command encrypts files for regular MUC #1449

wstrm opened this issue Dec 9, 2020 · 0 comments · Fixed by #1450
Assignees
@wstrm
Labels
bug OMEMO
Milestone
0.10.0

Comments

@wstrm
Copy link
Contributor

wstrm commented Dec 9, 2020

@mdosch discovered that the sendfile command encrypts files for regular MUC.

Expected Behavior

/sendfile should send a https://... URL in regular MUCs

Current Behavior

/sendfile encrypts the file using AES GCM (aesgcm:// URL) due to #1262

Possible Solution

Fix the switch in cmd_funcs.c.

Steps to Reproduce (for bugs)

  1. Enter a regular MUC
  2. Do /sendfile image.jpeg
  3. Voila!

Context

N/A

Environment

N/A
@wstrm wstrm self-assigned this Dec 9, 2020
wstrm added a commit to wstrm/profanity that referenced this issue Dec 9, 2020
@wstrm
Cast chat/muc window to correct type and refactor cmd_sendfile
00dbc1b 
Fixes profanity-im#1449
@wstrm wstrm mentioned this issue Dec 9, 2020
Merged
@jubalh jubalh added this to the 0.10.0 milestone Dec 10, 2020
jubalh added a commit that referenced this issue Dec 10, 2020
@jubalh
Remove not needed initialization in chatwin_new()
3703879 
00dbc1b attempted to fix
#1449.

Here we revert the part about initializing is_omemo in chatwin_new()
since this is done in win_create_chat() already.

The actual mistake was the wrong cast of the muc window which is fixed
by the same commit. The mistake was introduced in in 3370418.

While being at it we also remove the is_ox initialization since this is
handled in win_create_chat()/win_create_muc() too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wstrm wstrm

Labels
bug OMEMO
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Cast chat/muc window to correct type and refactor cmd_sendfile wstrm/profanity
2 participants
@jubalh @wstrm