Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make people love Profanity #1520

Closed
jubalh opened this issue Apr 14, 2021 · 1 comment
Closed

Make people love Profanity #1520

jubalh opened this issue Apr 14, 2021 · 1 comment
Assignees
@jubalh
Milestone
0.11.0

Comments

@jubalh
Copy link
Member

jubalh commented Apr 14, 2021

Our brilliant plan to make Profanity famous among the XMPP community was a huge success.

Profanity became a constant hit for discussions in the community. Everybody was and is talking about its huge IDs.

Now that we have achieved making people aware of Profanitys existence it's time to make them love Profanity.
So let's have shorter IDs.
@jubalh jubalh added this to the 0.11.0 milestone Apr 14, 2021
@jubalh jubalh self-assigned this Apr 14, 2021
jubalh added a commit that referenced this issue Apr 14, 2021
@jubalh
Goodbye beautiful IDs
8c50b63 
It was a great ride!

IDs look instead of
`TE5BTDc2ZTc3YTMwZGU3MDgzMzllOTliNGExNjVmMjZkMTY1ZmUyZGEyNTUxMjVmODBkMmQzOGMxYWI2ZjAxNzdiM2Q=`
more like `7HcnNSoO1MVvb0p9a9e293152922853e910b8b1a65bb26e225a0568` now.

Regards #1520

We still has our identifier into it to filter MUC reflected messages.

profident maybe should be changed to be longer or be generated upon each
start.
@jubalh
Copy link
Member Author

jubalh commented Apr 14, 2021 •
edited
Loading

Looking like 7HcnNSoO1MVvb0p9a9e293152922853e910b8b1a65bb26e225a0568 now. Sad :(
Edit: at least no UUID. So we are still special.

jubalh added a commit that referenced this issue Apr 17, 2021
@jubalh
Fix random string generation
8e588d6 
Our variable `alphabet` contains 62 alphanumeric symbols + '\0'.
When we use sizeof(alphabet) we will get 63 due to that.
But we want to choose a random numbers from the 62 alphanumeric letters only.

This mistake caused us to have strings with a max length of `length`
instead of the exact length.

When doing #1520
this caused our algo for muc reflection to not catch since we expect the
random ID to be exactly 15 symbols long in `message_is_sent_by_us()`.
@jubalh jubalh closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jubalh jubalh

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
1 participant
@jubalh