New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle detection via xscreensaver does not work #1695
Comments
Hmm could indeed be a regression in 0.12.x that occurred from our build files cleanup. Can you test with an earlier version and see if it works there? |
Sure, just tested with an old package and I can confirm that the issue is not present with 0.11.1. |
Using pkg-config to find libraries requires explicit mention of the relevant _CFLAGS and _LIBS variables. Fixes profanity-im#1695.
@lynix please test latest master. |
I have modified the Arch PKGBUILD to include b4857c6 as a patch against 0.12.1. I can see that Unfortunately the issue is still present, status is set to 'away' but not back. I'll try to build a package from master and see if that makes a difference. |
Same results with master version, status set to 'away' no matter if I move the mouse or not. |
Using pkg-config to find libraries requires explicit mention of the relevant _CFLAGS and _LIBS variables. Fixes profanity-im#1695.
So the issue is still present with 0.13.1, anything I can do to help getting this fixed? |
Sorry, I don't use a screensaver myself which is why this was not high prio for me. I also see that @paulfertser made some changes to the configure to try to fix this (thanks again).
Hmm weird. @sjaeckel do you have an idea? |
I don't use a screensaver either but I tend to walk around in my office and speak to other colleagues (in the same room). I then somewhat rely on the auto-away feature so my contacts get an indication that I'm not at my desk and can't read what they are sending me. Being permanently 'away' for the past few months has earned me some questions from my boss. I guess I will disable auto-away for now and hope I'll not forget to set it manually when going out for lunch. |
If I'm not mistaken you are a developer yourself, right? Were you able to find anything out that was not mentioned so far? |
Yes I am but I'm afraid I've got no new findings. As the executable is still not linked against libXss I'd assume all the parts that are guarded by Unfortunately autoconf/automake is black magic to me, so I haven't been able to figure out what could cause libXss to not be included despite b4857c6. |
In 28a9605 we migrated from AC_CHECK_LIB which defines HAVE_LIBXSS automatically. With pkg-config way you need it explicit. And also x11 is needed or else linking will fail missing XFree(). Patch provided by Paul Fertser and comitted by jubalh. Thanks Paul! Fix profanity-im#1695
Expected Behavior
Status is set to 'away' when mouse movements are stopped longer than
autoaway.awaytime
seconds and back to 'online' once mouse is moved again.Current Behavior
Status is set to 'away' after configured timeout but not restored to 'online' if mouse is moved. It is restored to 'online' once commands are typed.
Possible Solution
I have noticed that neither the binary nor the library is linked against
libXss.so
, which should be the case with--with-xscreensaver
being supplied toconfigure
.Checking configure.log I found
xscrnsaver_LIBS='-lXss '
so the configure stage seems to have found the library viapkgconf
, but somehow that library does not make it intoLIBS
.Unfortunately I don't know enough about autoconf/automake to trace this further down. Could it be a side effect of 28a9605?
Steps to Reproduce (for bugs)
--with-xscreensaver
, see below)Environment
Output of
profanity -v
:Arguments to
configure
from Arch Linux package:The text was updated successfully, but these errors were encountered: