-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a URL or avatar freezes Profanity for as long as the opened executable is currently running #1759
Comments
Doesn't happen to me and neither to @mdosch. Which executable did you set? So I can test with that one. |
But sounds like this would make sense anyways. Will you open a PR for this? |
Sure |
So to clarify: if people use |
|
Drawback is that we can't check the exitcode anymore. But we were unsure why/when we need this, see: https://github.com/profanity-im/profanity/pull/1760/files#r980868708 Fixes profanity-im#1759
Expected Behavior
Being able to use profanity while the opened executable is running
Current Behavior
Profanity freezes until I kill the opened executable
Possible Solution
Replace
g_spawn_sync
withg_spawn_async
incall_external
Steps to Reproduce (for bugs)
/url open
set to open a browser, for example like Firefox or Chromium/url open
Context
This is noticable, if for example,
/url open
opens a new browserEnvironment
The text was updated successfully, but these errors were encountered: