Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new /privacy group of commands #1836

Closed
jubalh opened this issue Apr 18, 2023 · 2 comments · Fixed by #1870
Closed

Introduce new /privacy group of commands #1836

jubalh opened this issue Apr 18, 2023 · 2 comments · Fixed by #1870
Assignees
Labels
Milestone

Comments

@jubalh
Copy link
Member

jubalh commented Apr 18, 2023

Idea started here: #1827 (comment)

I think we could use something like a new /privacy command.

Recently we received

I think we should group them together in something like /privacy.

And maybe also include other already existing commands in there:

  • /os
  • /silence ?
  • ..?

I also think the accounts structure can get too bloated. And we should put some things in a different structure. The settings still can be individual per account. But leave the account structure for really account related settings (I hope you get what I mean).

And things like session alarm need to be off by default and configurable by the user.
So we also need to check that preference like mentioned in: #1827 (comment)

@jubalh
Copy link
Member Author

jubalh commented Apr 18, 2023

I think /privacy can also mention/forward to other commands to look at.
For example we could implement XEP-0441: Message Archive Management Preferences and add it to /mam and mention it in privacy. Similar like we do in /color where it prints:

Consistent color generation for nicks (/color)                     : OFF 
Consistent color generation in roster (/roster color)              : OFF 
Consistent color generation for occupants (/occupants color)       : OFF

@jubalh jubalh added this to the next milestone Apr 18, 2023
@H3rnand3zzz
Copy link
Contributor

Introduced in #1857, but since the design is yet to be completed, I did not introduce full set and limited it to logging, to keep things simple, especially since it's a new feature. I would suggest to add additional commands after logging integration. We can gradually introduce them or use full command reference to add all suitable commands at once.

H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 2, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 3, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 3, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 3, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 3, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 8, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Jul 11, 2023
Add ability to completely turn logs off,
Needed since `/logging` and `/history` didn't stop history logging
in the DB, only in files.
Command might break something on usage,
hence it was primarily introduced for privacy geeks.
Privacy command discussion profanity-im#1836
jubalh added a commit that referenced this issue Jul 25, 2023
jubalh added a commit that referenced this issue Jul 25, 2023
jubalh added a commit that referenced this issue Jul 25, 2023
jubalh added a commit that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants