Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ox carbons from own messages show the full encrypted stanza #1875

Closed
mdosch opened this issue Aug 9, 2023 · 0 comments · Fixed by #1878
Closed

Ox carbons from own messages show the full encrypted stanza #1875

mdosch opened this issue Aug 9, 2023 · 0 comments · Fixed by #1878
Assignees
@jubalh
Labels
bug
Milestone
next

Comments

@mdosch
Copy link
Contributor

mdosch commented Aug 9, 2023

I have two instances of profanity running on two computers.
I write Ox encrypted to someone from profanity A, in profanity B my own message is shown as follows:

09.08.23 21:48:26 % me: <signcrypt xmlns="urn:xmpp:openpgp:0"><to jid="RECIPIENT_REDACTED"/><timestamp="2023-08-09T21:48:25+0200"/><rpad>RUiqtGIiOOBPPL</rpad><payload><body xmlns="jabber:client">CONTENT_REDACTED</body></payload></signcrypt>

Expected Behavior

See only body.

Current Behavior

The complete decrypted payload is shown.

Possible Solution

Steps to Reproduce (for bugs)

  1. Have two profanities running with the same account.
  2. Message a contact using Ox.
  3. Have a look at the conversation from the other profanity instance.

Context

Environment

  • Debian Testing
profanity --version
Profanity, version 0.14.0
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2023 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.11.4)
GTK icons/clipboard: Enabled
GDK Pixbuf: Enabled
@jubalh jubalh added the bug label Aug 10, 2023
@jubalh jubalh added this to the next milestone Aug 10, 2023
@jubalh jubalh self-assigned this Aug 25, 2023
jubalh added a commit that referenced this issue Aug 25, 2023
@jubalh
ox: correctly recognize ox encrypted carbons
122434a 
and dont display them as legacy pgp encrypted messages.
This was forgotten in 2c94ee5.

Fix #1875
@jubalh jubalh mentioned this issue Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jubalh jubalh

Labels
bug
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

ox: correctly recognize ox encrypted carbons profanity-im/profanity
2 participants
@jubalh @mdosch