Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prof_pre_chat_message_display does not replace sent messages #1917

Closed
H3rnand3zzz opened this issue Nov 9, 2023 · 0 comments · Fixed by #1918
Closed

prof_pre_chat_message_display does not replace sent messages #1917

H3rnand3zzz opened this issue Nov 9, 2023 · 0 comments · Fixed by #1918
Assignees
@H3rnand3zzz
Labels
improvement
Milestone
next

Comments

@H3rnand3zzz
Copy link
Contributor

Expected Behavior

prof_pre_chat_message_display is being called for sent messages as well

Current Behavior

It's being called only for loaded messages from the DB (sent and received), but not for sent messages. First report is here profanity-im/profanity-plugins#23

Possible Solution

call it for sent messages as well

Steps to Reproduce (for bugs)

  1. /plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/emoticons.py
  2. Send a message
  3. Message is not being replaced
  4. /close and /msg same_recipient and you'll see that replacement works.

Environment

Master branch
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 9, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
87de207 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages.
Fix profanity-im#1917
@H3rnand3zzz H3rnand3zzz mentioned this issue Nov 9, 2023
Merged
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 10, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
ec0d1e4 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages.
Fix profanity-im#1917
@jubalh jubalh added this to the next milestone Nov 10, 2023
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
b545532 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages.
Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
2607190 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages. Before the change, the function was not
called for sent messages upon sending, but only on fetching
sent messages from DB.
Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
a4c2605 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages. Before the change, the function was not
called for sent messages upon sending, but only on fetching
sent messages from DB.
Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
010efbd 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages.
Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Improve chatwin_outgoing_msg for message display consistency
4d219ce 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages. Before the change, the function was not
called for sent messages upon sending, but only on fetching
sent messages from DB.

Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Fix: add plugins_pre_chat_message_display call for outgoing messages
b19f668 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages. Before the change, the function was not
called for sent messages upon sending, but only on fetching
sent messages from DB.

Fix profanity-im#1917
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Dec 28, 2023
@H3rnand3zzz
Fix: add plugins_pre_chat_message_display call for outgoing messages
de51730 
Ensure consistent invocation of `plugins_pre_chat_message_display`
for outgoing messages. Before the change, the function was not
called for sent messages upon sending, but only on fetching
sent messages from DB.

Fix profanity-im#1917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@H3rnand3zzz H3rnand3zzz

Labels
improvement
Projects
None yet
Milestone
next
2 participants
@jubalh @H3rnand3zzz