Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slashguard doesn't work #1955

Closed
mdosch opened this issue Feb 17, 2024 · 2 comments
Closed

Slashguard doesn't work #1955

mdosch opened this issue Feb 17, 2024 · 2 comments
Labels
bug
Milestone
next

Comments

@mdosch
Copy link
Contributor

mdosch commented Feb 17, 2024

I realized that slashguard stopped working

Expected Behavior

Slashguard won't let you send a message like s/test.

Current Behavior

It's possible to send s/test

Steps to Reproduce (for bugs)

  1. Type s/test into a chat.
  2. See that the message is not blocked by slashguard but sent.

Environment

Debian testing/unstable

profanity --version
Profanity, version 0.14.0dev.master.569e37f0
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2024 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons/clipboard: Disabled
GDK Pixbuf: Enabled
@jubalh
Copy link
Member

jubalh commented Feb 17, 2024

Probably has to do with 7eac636 and inp_callback().

@jubalh jubalh added the bug label Feb 17, 2024
@jubalh jubalh added this to the next milestone Feb 17, 2024
jubalh added a commit that referenced this issue Feb 17, 2024
@jubalh
WIP: slashguard fix
008a04c 
* Need more time to investigate the callback stuff.
* Need to check whether we need the slashguard check in two locations or
  not. If we do put it into a func.

Fix #1955
@jubalh jubalh mentioned this issue Feb 17, 2024
Closed
jubalh added a commit that referenced this issue Feb 18, 2024
@jubalh
Fix slashguard
9b193b1 
Slashguard wasn't working since merging
#1943.

In 7eac636 the user input processing
was moved to be in gmainloop via inp_add_watch().

Fix #1955
jubalh added a commit that referenced this issue Feb 19, 2024
@jubalh
Undo gmainloop related changes
88b26cf 
Revert "Merge pull request #1943 from H3rnand3zzz/gmainloop

This reverts commit 609fde0, reversing
changes made to 2ec9406.

Revert "Merge pull request #1948 from H3rnand3zzz/fix/rl-less-refreshes"

This reverts commit 11762fd, reversing
changes made to 609fde0.

We have got several issues, that we don't quite see how to solve, with
the merge of the gmainloop PR.

* Slashguard is broken (#1955) (though #1956 could fix that)
* One person reported problems with copy paste selection via mouse
* Some input buffer seems not to be cleared correctly
  It happened that I was debugging profanity used `/connect` and typed
  the password. I then debugged so long that a time out occurred, so
  profanity disconnected. Then it printed "unknown command: $password".

There was something else that I forgot now.

Bottomline is: so far we didn't get it right so we will undo these
changes until someone proposes a working solution.

We got a slight performance increase (apparently noticable when
alt+mouse scrolling) but got too many issues with this change.
@jubalh
Copy link
Member

jubalh commented Feb 19, 2024

Solved in 88b26cf by reverting gmainloop changes.

@jubalh jubalh closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Fix slashguard profanity-im/profanity
2 participants
@jubalh @mdosch