Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global plugin installation dir #945

Closed
flocke opened this issue Jun 26, 2017 · 9 comments
Closed

Global plugin installation dir #945

flocke opened this issue Jun 26, 2017 · 9 comments
Assignees
Milestone

Comments

@flocke
Copy link

flocke commented Jun 26, 2017

Would it be possible to create a global plugin location so it would be easier for packagers to distribute plugins?

For example I could package the OMEMO plugin and have it installed directly in the right place without the user having to copy/link a file manually to ~/.local/share/profanity/plugins/ afterwards.

I would suggest something like ${DATADIR}/profanity/plugins (e.g. /usr/share/profanity/plugins) for python plugins and ${LIBDIR}/profanity/plugins (e.g. /usr/lib/profanity/plugins or /usr/x86_64-pc-linux-gnu/lib/profanity/plugins) for C plugins.

@philipflohr
Copy link
Contributor

@boothj5 @jubalh what do you think of this?
IMO this is a good idea, but as omemo gets implemented in profanity I don't know if there are any plugins worth getting packaged;)

@jubalh
Copy link
Member

jubalh commented Feb 22, 2019

I agree that this is a good idea. Even though OMEMO is planned to be implemented in profanity directly, this feature makes sense.

Looking for plugins in ${LIBDIR}/profanity/plugins sounds right.

@philipflohr
Copy link
Contributor

According to https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html the proposal of @flocke to seperate c and python plugins should be used.

@jubalh
Copy link
Member

jubalh commented Feb 26, 2019

Good point! I didn't know about it.

@jubalh
Copy link
Member

jubalh commented Oct 21, 2019

@philipflohr do you want to implement this?

@jubalh
Copy link
Member

jubalh commented Jun 3, 2020

@philipflohr ping :)

@jubalh
Copy link
Member

jubalh commented Jun 9, 2021

@philipflohr ?

@jubalh
Copy link
Member

jubalh commented Jun 9, 2021

@mwuttke97 maybe something for you?

@jubalh jubalh self-assigned this Sep 21, 2021
@jubalh jubalh added this to the 0.12.0 milestone Sep 21, 2021
@jubalh jubalh added the plugins label Sep 28, 2021
jubalh added a commit that referenced this issue Sep 29, 2021
Two options to install plugins.
Mention the whole path:
`/plugins install ~/src/profanity-plugins/my.py`

Mention only the plugin name:
`/plugins install my.py`

The latter will look in `/usr/local/share/profanity/plugins/` for the
file and copy it over to `~/.local/share/profanity/plugins`.

At first I was thinking about loading the plugins from the global
location. But users most likely don't want to have all plugins activated
that an admin installs on a system.

Regards #945
jubalh added a commit that referenced this issue Sep 29, 2021
Packagers can package https://github.com/profanity-im/profanity-plugins
or another collection of plugins to `/usr/local/share/profanity/plugins`
(python) and `/usr/local/lib64/profanity`  (c).
`/plugins` will list these globally available plugins now along with the
ones thare are installed (`~/.local/share/profanity/plugins`) and loaded.

Regards #945
jubalh added a commit that referenced this issue Sep 29, 2021
Two options to install plugins.
Mention the whole path:
`/plugins install ~/src/profanity-plugins/my.py`

Mention only the plugin name:
`/plugins install my.py`

The latter will look in `/usr/local/share/profanity/plugins/` for the
file and copy it over to `~/.local/share/profanity/plugins`.

At first I was thinking about loading the plugins from the global
location. But users most likely don't want to have all plugins activated
that an admin installs on a system.

Regards #945
jubalh added a commit that referenced this issue Sep 29, 2021
Packagers can package https://github.com/profanity-im/profanity-plugins
or another collection of plugins to `/usr/local/share/profanity/plugins`
(python) and `/usr/local/lib64/profanity`  (c).
`/plugins` will list these globally available plugins now along with the
ones thare are installed (`~/.local/share/profanity/plugins`) and loaded.

Regards #945
@jubalh
Copy link
Member

jubalh commented Sep 29, 2021

#1598 got merged.

@jubalh jubalh closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants