Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download user avatars (according to xep-0084) #1240

Merged
merged 15 commits into from Dec 18, 2019
Merged

Conversation

@jubalh
Copy link
Member

jubalh commented Dec 18, 2019

Add the possibility to download users avatars if they were published via xep-0084.

jubalh added 15 commits Dec 18, 2019
So far we just subscribe and get the IDs.
Proof of concept.
Needs error checking, a nice interface, general cleanup..
So far we removed the avatar feature only after a succesful retrive in
avatar_request_item_by_id() before we are going to retrieve the actual
image.

We should remove it at every `/avatar barejid` call too so in case one
retrieval was unsucessful that we can call it again.

So far it seems like there is no other way to trigger getting the nodes
except announcing that we support the avatar feature.
@jubalh jubalh added the feature label Dec 18, 2019
@jubalh jubalh added this to the 0.8.0 milestone Dec 18, 2019
@jubalh jubalh self-assigned this Dec 18, 2019
@jubalh jubalh merged commit 46478df into master Dec 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jubalh jubalh deleted the feature/xep-0084-user-avatar branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.