[OMEMO]: Fix bundle publishing #1496
Conversation
ghost
mentioned this pull request
Do you know which ones? |
|
On 08/03/2021 20:19, Michael Vetter wrote:
Do you know which ones?
This holds at least for Prosody. I created an issue there [1], where
they linked to a XEP PR that explains this decision. [2]
[1]: <https://issues.prosody.im/1643>
[2]: <xsf/xeps#988>
|
|
On 08/03/2021 20:44, Michael Vetter wrote:
maybe you can also ammend this commit to include the links to prosody
that you added as comments to this PR
Haha, I forgot to remove some comments. Thanks for reviewing. :-)
Yes, I will do.
|
ghost
requested a review
from
|
Hi, I just checked the diff again. I don't see any accidental comments any more. I've also tested it once more. One notable change (introduced by @StefanKropp) that I noticed is that when OMEMO is activated by default but no crypto material has been generated yet, the following will be written to the console:
This should remind the user to generate crypto material first. |
|
Thanks for the updates. I think the PR looks good now. I'm uncertain whether some of the log_info() should actually be log_debug() though. But I see that this is debatable and there is no common rules for it yet in Profanity. @StefanKropp could you also give it a quick review? |
Reduce the request during startup of profanity Removed omemo_start_sessions from sv_ev_roster_received
Also "handle" some errors in `_omemo_bundle_publish_configure` if the stanzas can't be found
Use the following options in `omemo_bundle_publish()`: - "pubsub#persist_items" = "true" - "pubsub#access_model" = "open" The same options are also used in Gajim. I've tested this on two different servers. The bundle was successfully added as a new PEP node. Test cases: 1. Normal use on my main account 2. Log in into a fresh tesst account on a different server 3. `/omemo clear_device_list`. In this case, the client(s) may have to be restarted. Note: In `_omemo_bundle_publish_result`, there's a route that is taken when the bundle publish stanza failed. In this case, the node is configured manually, i.e. the access_model is set to 'open'. I have manually tested this case, but this case didn't naturally occur for me. Note: The option "pubsub#max_items=max" is REQUIRED for the bundle publication, as per XEP-0384. However, this is not done in other clients (I've checked the source code of Gajim and Conversations), and it is also not supported by Prosody. Cf. <xsf/xeps#988>.
|
I just force-pushed to fix the mail address in my commits. I didn't change anything else. |
|
Got an ACK from @StefanKropp via PM. |
This PR fixes #1492 and subsumes #1486.