Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty window after reconnect #1808

Conversation

MarcoPolo-PasTonMolo
Copy link
Collaborator

Sometimes after a reconnect the current window would get cleared. This was a deliberate change to fix the profanity window looking all garbled up after providing the passphrase for a gpg key using pinentry-curses.
See 6034b83

Fixes #1556

Sometimes after a reconnect the current window would get cleared. This
was a deliberate change to fix the profanity window looking all garbled
up after providing the passphrase for a gpg key using pinentry-curses.

Fixes profanity-im#1556
@jubalh jubalh self-requested a review April 2, 2023 21:30
@jubalh jubalh added this to the next milestone Apr 2, 2023
@jubalh
Copy link
Member

jubalh commented Apr 2, 2023

@mdosch

@MarcoPolo-PasTonMolo
Copy link
Collaborator Author

MarcoPolo-PasTonMolo commented Apr 3, 2023

Btw here's how I reproduced the bug:

  1. Added a pgp.keyid=SOME PGP KEY to my account in the profanity accounts file
  2. open profanity you'll notice now that you have the pgp key at some point the welcome screen clears (you can't see the profanity logo)
  3. /msg a contact
  4. /xmlconsole
  5. type < in xmlconsole and send it, now we have lost connectivity
  6. got to the window of the contact, type /reconnect now
  7. the window should clear.

Doing this after the fix shouldn't clear the window. And yes you do need to have a pgp.keyid to your account or this probably shouldn't happen

Copy link
Member

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay lets try it! :)

@jubalh jubalh merged commit a086cfb into profanity-im:master Apr 3, 2023
@mdosch
Copy link
Contributor

mdosch commented Apr 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message window is empty after reconnect
3 participants