Use ASCII chars for MAM loading string #1820

alexandre1985 · 2023-04-05T07:24:36Z

Fix non-ASCII chars, for correct display in TTY
UTF-8 personal names are excluded from this fix

jubalh · 2023-04-05T10:31:41Z

Illegal chars? What's illegal about them?
I guess what you want to say is Use only ASCII characters in MAM loading string.

This change was introduced by @mdosch in #1773.

I can see a point in only using ASCII chars but I can also see a point in being a bit modern.

Maybe an alternative would be to configure your TTY: https://askubuntu.com/questions/23610/how-to-enable-unicode-support-in-a-tty

alexandre1985 · 2023-04-05T11:09:00Z

@jubalh I use GNU Screen in my TTY and it doesn't show this chars correctly.
I have tried quitting GNU Screen, run unicode_start and still my TTY doesn't show those "illegal chars" correctly.

My system is Artix Linux and my TTY have lat9w-16 for the console font and 8859-1_to_uni as the console translation. My unicodemap is iso01. Is something missing to make the TTY more modern?

Maybe I should rename the commit. Asking suggestion for another name in place of "illegal chars".

alexandre1985 · 2023-04-05T11:14:51Z

@jubalh I did check all files in the source code for "illegal chars", so that is why I am not referencing a single string or file.

One personal names in the copyright top comment of some files, was also being detected, but since it is a comment and since it is a personal name, I did not change it.

Also, besides that name being non-ASCII it renders well on my TTY.

jubalh · 2023-04-05T11:19:19Z

I did check all files in the source code for "illegal chars", so that is why I am not referencing a single string or file.

In this kind of commit description how you got to this end result doesn't matter much. What you do change in this commit matters. And UTF-8 is nothing illegal ;)

One personal names in the copyright top comment of some files, was also being detected, but since it is a comment and since it is a personal name, I did not change it.

This and the fact that we use UTF-8 encoding for source files anyways.

Commit is now:

Fix char in MAM string to view it in TTY

 * Fix chars, for correct display in TTY. All source code files have
 been checked.
 * UTF-8 personal names are excluded from this fix.

And again I'm confused about the description. It's not a "fix".

alexandre1985 · 2023-04-05T11:26:09Z

@jubalh Ok, UTF-8 is not illegal. My phrasing could have been better. Please check now if it is acceptable.

alexandre1985 · 2023-04-05T11:29:02Z

And again I'm confused about the description. It's not a "fix".

@jubalh It would be better if you tell me what it is (instead of telling what is not). So that I may write a better commit message.

jubalh · 2023-04-05T11:36:10Z

It would be better if you tell me what it is (instead of telling what is not). So that I may write a better commit message.

You mean like in my first comment #1820 (comment) where I wrote I guess what you want to say is **Use only ASCII characters in MAM loading string** ?

* MAM loading string char to ASCII, for better display in all TTYs. * All source code files have been checked, and there is no other issue for TTYs chars display. Signed-off-by: Daniel Santos <dacs.git@brilhante.top>

alexandre1985 · 2023-04-05T15:06:29Z

@jubalh is the new force push better?

mdosch · 2023-04-05T18:00:48Z

As I already said in the MUC: … is not an illegal character and it works fine in my TTY. I guess you have either some misconfiguration or you use a font which can't show the character …. I think you should rather fix your TTY to also show non-ASCII characters than patching this out.
To check/change your setup do the following in Debian (I don't know how to do this on other distros):

# dpkg-reconfigure console-setup

alexandre1985 · 2023-04-05T18:40:33Z

Terminus shows the ellipsis char correctly in my terminal.

@mdosch So, you prefer to enforce a terminal font in all profanity users, than making this little adjustment?

I actually dislike terminus font look.

mdosch · 2023-04-05T18:43:50Z

You don't have to settle with Terminus, there are many more fonts which should support UTF8, so it's not like Terminus is enforced on all users. Also I think limiting characters to ASCII because people might use a font which doesn't support UTF8 is not a good solution. Anyway, I am not the one to decide…

…

On 05.04.2023 11:40, Daniel Santos wrote: Terminus shows the ellipsis char correctly in my terminal. @mdosch So, you prefer to enforce a terminal font in all profanity users, than making this little adjustment? I actually dislike terminus font look. -- Reply to this email directly or view it on GitHub: #1820 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

alexandre1985 · 2023-04-05T18:49:15Z

I want my font to be lat9w-16. And profanity does not display well that font.

Such a simple fix, there are many other '...' (3 dots) in the code. Why this resistance?

alexandre1985 · 2023-04-05T19:08:05Z

You don't have to settle with Terminus, there are many more fonts which should support UTF8, so it's not like Terminus is enforced on all users. Also I think limiting characters to ASCII because people might use a font which doesn't support UTF8 is not a good solution. Anyway, I am not the one to decide…

When typing "in am not the one to decide..." why didn't you use the ellipsis char, instead of the 3 dots?

Would be awesome to know, and this might lead somewhere...

mdosch · 2023-04-05T19:11:16Z

On 05.04.2023 12:08, Daniel Santos wrote: When typing "in am not the one to decide..." why didn't you use the ellipsis char, instead of the 3 dots?

That's exactly what I did… 🤣

alexandre1985 · 2023-04-05T19:19:25Z

On 05.04.2023 12:08, Daniel Santos wrote: When typing "in am not the one to decide..." why didn't you use the ellipsis char, instead of the 3 dots?
That's exactly what I did… rofl

Yes, I did a mistake.

alexandre1985 · 2023-04-05T20:22:53Z

I just counted, the 3 dots are printed 26 times by profanity. The ellipsis char is printed 1 time by profanity. Choose one. @mdosch

alexandre1985 · 2023-04-06T12:25:51Z

Here is my case:

In order for this project be consistent to the user, I am considering that for strings printed to the user, the project will either use 3dots or the ellipsis char for all cases.

=== 3dots ===

** Advantages **

Works in all TTY displays, independent of TTY font.
User is free to choose whatever font they wish for their TTY.
Needs to change 1 entry of commited work from 1 developer, instead of 26 entries from numerous developers.

** Disavantages **

None.

=== Ellipsis char ===

** Advantages **

Use a new char.

** Disavantages **

Doesn't work in all TTY displays, independent of TTY font.
Forcing user to use a small group of today's TTY fonts.
Needs to change 26 entries of commited work from numerous developers, instead of 1 entry from one developer.
The new ellipsis char has always been replaced by 3dots chars, before the ellipsis char existence. It is redundant.

=====

If it is chosen to not do a thing, consistency is lost and is gained Ellipsis Disavantage 1. and 2., Ellipsis advantage 1. and not doing any commit.

Choose wisely.

jubalh · 2023-04-08T16:20:54Z

I updated the PR title for you, please do this the next time as well.

I checked on both my Gentoo and openSUSE machines. On both Unicode on TTY works without problems. All with default settings, I didn't change/configure anything in this regard manually.

alexandre1985 · 2023-04-09T09:02:51Z

Such a simple to approve PR. A no-brainer.

You have definitely not tried on Arch Linux. It does not work in Arch. Arch Linux has a much bigger number of users than either Gentoo or OpenSUSE.

And I guess you don't want consistency in on Profanity. What a poor decision.

I updated the PR title for you, please do this the next time as well.

There is no need, there won't be a next PR from me.

sjaeckel · 2023-04-09T09:57:27Z

btw. I'm using Arch as well, and it works for me

alexandre1985 · 2023-04-09T10:00:30Z

btw. I'm using Arch as well, and it works for me

It does not work on the TTY with the default font (lat1-16 or lat9w-16).

mdosch · 2023-04-09T10:02:35Z

On 09.04.2023 03:00, Daniel Santos wrote: > btw. I'm using Arch as well, and it works for me It does not work on the TTY with the default font (lat1-16 or lat9w-16).

What do you mean by _it does not work_? Is profanity crashing? I guess you should just see an replacement char if your font does not support UTF8 which should be no big deal. Without an UTF8 font you will see those already often in every chat where people use UTF8 chars or emoji…

As stated in profanity-im#1820 (comment) profanity uses "..." (three dots) in a lot of places instead the proper ellipsis char "…".

H3rnand3zzz approved these changes Apr 5, 2023

View reviewed changes

Use ASCII char in MAM loading string

27ed150

* MAM loading string char to ASCII, for better display in all TTYs. * All source code files have been checked, and there is no other issue for TTYs chars display. Signed-off-by: Daniel Santos <dacs.git@brilhante.top>

jubalh changed the title ~~Fix illegal chars~~ Use ASCII chars for MAM loading string Apr 8, 2023

jubalh closed this Apr 8, 2023

mdosch mentioned this pull request Apr 9, 2023

User proper ellipsis char #1821

Merged

mdosch added a commit to mdosch/profanity that referenced this pull request Apr 9, 2023

User proper ellipsis char

e1ffc64

As stated in profanity-im#1820 (comment) profanity uses "..." (three dots) in a lot of places instead the proper ellipsis char "…".

jubalh added the abuse label Apr 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ASCII chars for MAM loading string #1820

Use ASCII chars for MAM loading string #1820

alexandre1985 commented Apr 5, 2023

jubalh commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

jubalh commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023

jubalh commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023

mdosch commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023

mdosch commented Apr 5, 2023 via email

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

mdosch commented Apr 5, 2023 via email

alexandre1985 commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 6, 2023 •

edited

jubalh commented Apr 8, 2023

alexandre1985 commented Apr 9, 2023

sjaeckel commented Apr 9, 2023

alexandre1985 commented Apr 9, 2023

mdosch commented Apr 9, 2023 via email

Use ASCII chars for MAM loading string #1820

Use ASCII chars for MAM loading string #1820

Conversation

alexandre1985 commented Apr 5, 2023

jubalh commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023 • edited

alexandre1985 commented Apr 5, 2023 • edited

jubalh commented Apr 5, 2023 • edited

alexandre1985 commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023

jubalh commented Apr 5, 2023 • edited

alexandre1985 commented Apr 5, 2023

mdosch commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023

mdosch commented Apr 5, 2023 via email

alexandre1985 commented Apr 5, 2023 • edited

alexandre1985 commented Apr 5, 2023 • edited

mdosch commented Apr 5, 2023 via email

alexandre1985 commented Apr 5, 2023

alexandre1985 commented Apr 5, 2023 • edited

alexandre1985 commented Apr 6, 2023 • edited

jubalh commented Apr 8, 2023

alexandre1985 commented Apr 9, 2023

sjaeckel commented Apr 9, 2023

alexandre1985 commented Apr 9, 2023

mdosch commented Apr 9, 2023 via email

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

jubalh commented Apr 5, 2023 •

edited

jubalh commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 5, 2023 •

edited

alexandre1985 commented Apr 6, 2023 •

edited