Fix underscrolling problem #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is caused by ncurses library rendering only 1000 lines, while it's possible that we have long messages in the buffer. Current buffer limit is 200 messages, with just average size of message of 10 lines, ncurses buffer is being overflown and we render only part of the message. This causing a problem of "underscrolling": user is unable to scroll to the top or bottom and he is stuck somewhere in the middle of the history. It's not a permanent solution, but rather a temporary fix before introducing line-counting which will align Profanity's message buffer size in **lines** with ncurses' limits. It might be even adjustable setting in the future. The problem was caused by a faulty logic that 1 message = 1 line and it's a second try to address it, the try earlier was ea39657.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.