Fix scrolling state at windows edge #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW if you dont write "see commit message" and have only 1 commit. Then the commit message should be taken automatically. So with one commit it doesn't make sense to write this :) |
Maybe that commit should be mentioned as well. |
jubalh
reviewed
Dec 5, 2023
The problem: if user scrolled to the edge of the window, the state that edge is reached, transfers to other windows, rendering user unable to scroll further up/down in other windows as well. Make unique states for each window that show that edge of the DB is reached. Later it might be improved with MAM states as well to decrease load on program in cases when user keeps scrolling despite reaching the edge. Bug discovered by @atomicwatch, reported through the developers' MUC `SCROLL_INNER` naming suggestion by @jubalh
H3rnand3zzz
force-pushed
the
fix/db-edge-scrolling
branch
from
68c9667
to
0d29e05
Compare
jubalh
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message, it's descriptive.
No memory stuff -> no need for valgrind.