Allow stubbing without using IDs #5
Labels
Comments
jubalh
added a commit
to jubalh/profanity
that referenced
this issue
Aug 30, 2018
Functional tests were commented out because of: profanity-im#1010 An issue was raised for stabber: profanity-im/stabber#5 Once this issue is resolved functional tests should be enabled again.
jubalh
added a commit
to jubalh/profanity
that referenced
this issue
Aug 30, 2018
Functional tests were commented out because of: profanity-im#1010 An issue was raised for stabber: profanity-im/stabber#5 Once this issue is resolved functional tests should be enabled again.
|
Discovered through profanity-im/profanity#1010 profanity-im/profanity@171b6e7 disables functional tests in profanity. Once this issue is resolved a PR to re-enable them should be made or an issue created. |
|
@boothj5 I might take a look at this soon. What exactly is an example for 'stanza content' we should use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
stbbr_for_idfunctionality allows stubbing Stanza responses based on the Stanza ID.Clients generally use random numbers for IDs, so Stabber should never be reliant on them.
A better approach would be to stub a response based on the stanza contents.
The text was updated successfully, but these errors were encountered: