Fix: bug risks

profclems · Aug 14, 2020 · cb5e297 · cb5e297
1 parent d0e4f9e
commit cb5e297
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/commands/pipeline.go b/commands/pipeline.go
@@ -246,6 +246,9 @@ func getPipelineFromBranch(ref, repo string) ([]*gitlab.Job, error) {
 	}
 	pipeline := pipes[0]
 	jobs, err := getPipelineJobs(pipeline.ID, repo)
+	if err != nil {
+		return  nil, err
+	}
 	return jobs, nil
 }
 

diff --git a/commands/pipeline_ci_trace.go b/commands/pipeline_ci_trace.go
@@ -145,7 +145,7 @@ func runTrace(ctx context.Context, w io.Writer, pid interface{}, sha, name strin
 			}
 			fmt.Fprintf(w, "Showing logs for %s job #%d\n", job.Name, job.ID)
 		})
-		_, err = io.CopyN(ioutil.Discard, trace, offset)
+		_, _ = io.CopyN(ioutil.Discard, trace, offset)
 		lenT, err := io.Copy(w, trace)
 		if err != nil {
 			return err

diff --git a/commands/pipeline_status.go b/commands/pipeline_status.go
@@ -112,6 +112,10 @@ var pipelineStatusCmd = &cobra.Command{
 								er(err)
 							}
 							pipes, err = getPipelines(l, repo)
+							if err != nil {
+								er(err)
+								return
+							}
 							runningPipeline = pipes[0]
 							isRunning = true
 						}