This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix deepsource woes #424
Merged
Fix deepsource woes #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Function literals that only call a single function, without making any other changes to the value of the inner function, can be removed, as they are redundant. Instead, the inner function, that is being called inside the outer function should be called. https://deepsource.io/gh/profclems/glab/run/0801fe82-1e9c-42fd-acc7-affe7f2e2fbb/go/CRT-A0018/
From: https://golang.org/pkg/context/ Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. The Context should be the first parameter, typically named ctx https://deepsource.io/gh/profclems/glab/run/0801fe82-1e9c-42fd-acc7-affe7f2e2fbb/go/RVV-A0002/
maxice8
force-pushed
the
fix-deepsource-woes
branch
from
ac56ee0
to
6732be6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Series of commits that fix several issues found by deepsource
Related Issue
https://github.com/profclems/glab/pull/423/checks?check_run_id=1614976446
How Has This Been Tested?
The changes should not change behaviour
Types of changes