Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix(internal/glrepo/resolver): check for 'head' not 'head:' #437

Merged
merged 1 commit into from Dec 28, 2020
Merged

fix(internal/glrepo/resolver): check for 'head' not 'head:' #437

merged 1 commit into from Dec 28, 2020

Conversation

maxice8
Copy link
Collaborator

@maxice8 maxice8 commented Dec 28, 2020

Description

preivous one missed glab-resolved = head

Related Issue

Resolves #433

How Has This Been Tested?

On go playground

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@maxice8
fix(internal/glrepo/resolver): check for 'head' not 'head:'
33e94c3 
preivous one missed `glab-resolved = head`
@maxice8 maxice8 mentioned this pull request Dec 28, 2020
Closed
@maxice8
Copy link
Collaborator Author

maxice8 commented Dec 28, 2020 •
edited

The test: https://play.golang.org/p/or7DRHFKpV6

@profclems
Copy link
Owner

Thank you.
This fix is critical and I would have to do a patch release as soon as I merge this. Literally, I'm unable to use glab without this fix

@profclems profclems added this to In progress 📈 in GLab: A GitLab CLI Tool via automation Dec 28, 2020
@profclems profclems moved this from In progress 📈 to Needs Review 👀 in GLab: A GitLab CLI Tool Dec 28, 2020
@profclems profclems added the Fix This fixes a bug or incorrect documentation label Dec 28, 2020
@maxice8 maxice8 added the priority: high Affects a large population and inhibits work label Dec 28, 2020
profclems
profclems approved these changes Dec 28, 2020
View reviewed changes
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GLab: A GitLab CLI Tool automation moved this from Needs Review 👀 to Needs to be merged 🎉 Dec 28, 2020
@profclems profclems merged commit 83019fe into profclems:trunk Dec 28, 2020
GLab: A GitLab CLI Tool automation moved this from Needs to be merged 🎉 to Pending Release 🗞️ Dec 28, 2020
@clemsbot clemsbot moved this from Pending Release 🗞️ to Done 🤝 in GLab: A GitLab CLI Tool Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@profclems profclems profclems approved these changes

Assignees
No one assigned
Labels
Fix This fixes a bug or incorrect documentation priority: high Affects a large population and inhibits work size/XS
Projects
GLab: A GitLab CLI Tool
  
Done 🤝
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expected the "[HOST/]OWNER/[NAMESPACE/]REPO" format, got "head"
2 participants
@maxice8 @profclems