This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix(ci trace): exit normally when prompts are interrupted #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
鈥pecifically, interrupted via SIGINT (CTRL-C). Otherwise, the first job is chosen, which isn't a huge deal, but isn't really consistent with the user's wish to exit the program early
Codecov Report
@@ Coverage Diff @@
## trunk #849 +/- ##
==========================================
- Coverage 59.42% 59.38% -0.04%
==========================================
Files 93 93
Lines 7366 7370 +4
==========================================
Hits 4377 4377
- Misses 2607 2610 +3
- Partials 382 383 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
鈥pecifically, interrupted via SIGINT (CTRL-C). Otherwise,
the first job is chosen, which isn't a huge deal, but isn't really
consistent with the user's wish to exit the program early
Description
I noticed that if I do
glab ci traceand CTRL-C to exit, the first job gets chosen, rather than exiting.Related Issue
(none to my knowledge)
How Has This Been Tested?
I've only done manual testing so far; I'd run the automatic test suite but I don't want to blow my configuration away 馃槵
Screenshots (if appropriate):
N/A
Types of changes