Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lazy proxy typing #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

thepaperpilot
Copy link
Collaborator

Remaining work would be:

  • Update every other feature, and any relevant utilities (like in common.tsx)
  • Implement processComputable, or remove it since it might just be redundant now
  • Remember to delete the example achievement below the constructor, that I was using to verify typing was working
  • This code doesn't work, because feature gets typed as object:
function myFeature() {
    return createLazyProxy(() => {
        const foo = "bar";
        const points = createAchievement(() => ({

        }));
        return {
            foo, points
        };
    });
}

const feature = myFeature();
feature;
feature.foo;
feature.points;

Fixes #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant