Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Off Blades for EFFECT_BATTERY_LEVEL and others #314

Closed
fdarosa2663 opened this issue Oct 31, 2021 · 2 comments
Closed

Power Off Blades for EFFECT_BATTERY_LEVEL and others #314

fdarosa2663 opened this issue Oct 31, 2021 · 2 comments

Comments

@fdarosa2663
Copy link
Contributor

Need to ensure blade powers off for layers using EFFECT_BATTERY_LEVEL, EFFECT_BOOT, EFFECT_NEWFONT, EFFECT_PREON, EFFECT_POSTOFF, EFFECT_LOW_BATTERY

@profezzorn
Copy link
Owner

these three are handled:
EFFECT_BOOT,
EFFECT_PREON,
EFFECT_NEWFONT
here:

case EFFECT_BOOT:

that leaves:
EFFECT_BATTERY_LEVEL
EFFECT_POSTOFF
EFFECT_LOW_BATTERY

EFFECT_POSTOFF might require a little special working since it CAN occur after retraction, but only once, so after it is done, it can't occur again and we can return ZERO_UNTIL_IGNITION.

The other two I don't when they can occur.
If they can occur after retraction, then we should probably make sure that they power the blade on, then we can handle them the same way as EFFECT_NEWFONT.

@profezzorn
Copy link
Owner

I've made it so that all new effects turn the blade on.
This might not be the right thing to do for some effects, so we'll need to monitor and see if causes problems, but for now, this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants