Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_sftp should fail on startup when SFTP and TLS are both enabled for a vhost #1434

Closed
Castaglia opened this issue Apr 29, 2022 · 0 comments
Assignees
Milestone

Comments

@Castaglia
Copy link
Member

I have seen users' configurations where they are not using different <VirtualHost> sections for FTP/FTPS vs SFTP servers, and instead have e.g.:

<IfModule mod_tls.c>
  TLSEngine on
  ...
</IfModule>

<IfModule mod_sftp.c>
    SFTPEngine on
    ...
</IfModule>

This lets administrators think that they can support FTP/FTPS and SFTP using the same single vhost -- but they cannot. The protocols do not work that way.

So the scope of this task is to add detection of this sort of configuration to the mod_sftp module (since it is a contrib module, not a core module), and to log a warning to the system log when this happens. Or perhaps mod_sftp should check for such configurations on startup, and prevent the server from passing its config check? That would be better...

@Castaglia Castaglia added this to the 1.3.8 milestone Apr 29, 2022
@Castaglia Castaglia self-assigned this Apr 29, 2022
Castaglia added a commit that referenced this issue Apr 29, 2022
…p, if we detect both `SFTPEngine on` _and_ `TLSEngine on` in effect for the same vhost, we fail the startup.
Castaglia added a commit that referenced this issue Apr 30, 2022
Issue #1434: Add a conformance check to mod_sftp such that, on startu…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant