Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod_exec to use the Jot API for resolving variables #1630

Closed
Castaglia opened this issue Mar 13, 2023 · 3 comments
Closed

Update mod_exec to use the Jot API for resolving variables #1630

Castaglia opened this issue Mar 13, 2023 · 3 comments
Assignees
Milestone

Comments

@Castaglia
Copy link
Member

The scope of this ticket is to update the mod_exec module's variable substitution code here to instead use the Jot API, so that it automatically benefits from new variable additions there.

@offsides
Copy link
Contributor

I'm not really familiar with the jot API, but in principle this sounds like an excellent idea to centralize things and avoid code duplication.

@Castaglia
Copy link
Member Author

Castaglia commented Mar 16, 2023

I'm not really familiar with the jot API, but in principle this sounds like an excellent idea to centralize things and avoid code duplication.

The Jot API is ProFTPD's internal API that is used to resolve all of the LogFormat variables when writing e.g. ExtendedLog entries. It is also used, to support those LogFormat variables in things like SQLNamedQuery, and in logging modules like mod_redis and its ilk. So updating mod_exec to use this API as well (which it should be) is a Good Thing. I consider the fact that mod_exec does not use this API to be tech debt to be retired; it's one less place that implements its own handling of these variables.

Castaglia added a commit that referenced this issue Mar 16, 2023
…orting the normal range of `LogFormat` variables using the shared API for doing so.
Castaglia added a commit that referenced this issue Mar 16, 2023
Issue #1630: Update the `mod_exec` module to use the Jot API for supp…
@Castaglia
Copy link
Member Author

Addressed in master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants