Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elapsed time based scoreboard updates #1485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jul 6, 2022

  1. Issue proftpd#1433: Update PR_SCORE_XFER_DONE in pr_throttle_pause

    This has two advantages:
    
    - Update the scoreboard in a single call making xfer_done and elasped_time come
      from the same moment and reducing scoreboard update overhead
    - During FTP uploads the number of received bytes also get updated in XFER_DONE
      making ftpwho -o json display "transfer_bytes" for uploads as well
    
    Signed-off-by: Marton Balint <cus@passwd.hu>
    cus committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9bbcff3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Issue proftpd#1484: Update scoreboard at regular time intervals

    This commit removes the previously used blocksize or filesize percentage based
    scoreboard updates and starts using elapsed time based scoreboard updates.
    
    Percent based scoreboard updates could have been too infrequent for big files
    and slow link speeds, blocksize based scoreboard updates could have been too
    frequent for fast links.
    
    Also this changes the meaning of PR_TUNABLE_XFER_SCOREBOARD_UPDATES, previously
    it meant the number of transferred blocks to wait until a scoreboard update
    happened, now it means the number of deciseconds to wait between subsequent
    scoreboard updates.
    
    Deciseconds as the unit were chosen so the default of
    PR_TUNABLE_XFER_SCOREBOARD_UPDATES of 10 is unchanged and will mean a
    scoreboard update every second.
    cus committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4dfeb40 View commit details
    Browse the repository at this point in the history