Support extended file attributes via SFTP. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attribute operations.
XATTR_NOFOLLOW flag is not defined.
unimplemented getxattrs extended request, for now.
…s for protocol version 6 sessions.
… This is easier than requiring patching.
… adding two new SFTPOptions for ignoring xattrs on SETSTAT and OPEN requests, mirroring the existing options for ownership/permissions.
…O API, where they should be. This involves adding a --disable-xattr configure option, expanding the FSIO API and its unit tests, and refactoring the mod_sftp use of those calls.
…rotocol version 6.
… platforms, this is where the ENODATA/ENOATTR errno values are defined. Sigh.
…void issues (one defines the setxattr flag values using an enum, the other uses macros; what a mess).
…attr flag values.
…e value; this causes build failures with some picky/strict compiler flags.
…which rippled through the entire API. Almost ready.
to contain all of the xattrs for a file. This required some refactoring, to allow for possible resizing of the READDIR response buffer.
…ys/xattr.h> is used, not where <sys/extattr.h> is used (i.e. BSDs).
…ed to link, not just compile, to perfectly detect their presence. Silly compilers.
…INK and READDIR requests, though, a set of attribute flags had to be assumed, as those requests do not have a flags field defined.
ATTR_EXTENDED, as some clients (e.g. lftp) choke on those in FXP_NAMEs in a READDIR response.
…y need to make sure that if no xattrs are found, we still include the xattr count (i.e. of zero).
…ersion, rather than just for protocol version 4 and higher; they are defined for protocol version 3 as well.
…e defined and use the same value.
match. Make sure those new SFTPOptions are documented.
…ation file by the pr_fs_copy_file() function.
…ents) via a new FSOptions directive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #241 .