New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing release 2.0.0 #241
Conversation
…ing deps. Bumping version.
Leaving this here before I forget... It would be nice to get #230 done before a release. I think I can work on it this week. |
Nice - looking forward to this release! Maybe upgrade to Scala 2.12.10 as well? |
Yeah, I can do that too if there's no big issues! I didn't know 2.12.10 was out 😄 |
.settings(commonSettings: _*) | ||
.settings(libraryDependencies ++= JsonDependencies(scalaVersion.value)) | ||
.settings(parallelExecution in Test := false) | ||
.enablePlugins(AutomateHeaderPlugin) | ||
.dependsOn(`fs2-rabbit`) | ||
|
||
lazy val `fs2-rabbit-test-support` = project.in(file("test-support")) | ||
lazy val `fs2-rabbit-test-support` = project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this published? I should check that out, might be handy in my project :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It surely is :) https://search.maven.org/search?q=a:fs2-rabbit-test-support_2.13
val amqpClient = "5.7.3" | ||
val logback = "1.2.3" | ||
val monix = "3.0.0" | ||
val zio = "1.0.0-RC12-1" | ||
val zioCats = "2.0.0.0-RC3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should only release ourselves as RC
if one of our dependencies is at RC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are only for the examples.
@@ -1,2 +1,2 @@ | |||
version in ThisBuild := "2.0.0-RC3" | |||
version in ThisBuild := "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version in ThisBuild := "2.0.0" | |
version in ThisBuild := "2.0.0-RC4" |
Because of the zio dependency only. Your call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monix
and zio
are only pulled by the examples
which are not published as a dep.
Closes #234 and closes #235
Pinging @Daenyth to get the green light on this one.