Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 2.0.0 #241

Merged
merged 5 commits into from Sep 17, 2019
Merged

Preparing release 2.0.0 #241

merged 5 commits into from Sep 17, 2019

Conversation

gvolpe
Copy link
Member

@gvolpe gvolpe commented Sep 15, 2019

Closes #234 and closes #235

  • Dropping support for Scala 2.11.x as Circe does not support it.
  • Updating and unifying dependencies for the different Scala versions.
  • Bumping version.

Pinging @Daenyth to get the green light on this one.

@gvolpe gvolpe requested a review from Daenyth September 15, 2019 02:09
@gvolpe
Copy link
Member Author

gvolpe commented Sep 17, 2019

Leaving this here before I forget... It would be nice to get #230 done before a release. I think I can work on it this week.

@ybasket
Copy link
Contributor

ybasket commented Sep 17, 2019

Nice - looking forward to this release!

Maybe upgrade to Scala 2.12.10 as well?

@gvolpe
Copy link
Member Author

gvolpe commented Sep 17, 2019

Yeah, I can do that too if there's no big issues! I didn't know 2.12.10 was out 😄

build.sbt Outdated Show resolved Hide resolved
.settings(commonSettings: _*)
.settings(libraryDependencies ++= JsonDependencies(scalaVersion.value))
.settings(parallelExecution in Test := false)
.enablePlugins(AutomateHeaderPlugin)
.dependsOn(`fs2-rabbit`)

lazy val `fs2-rabbit-test-support` = project.in(file("test-support"))
lazy val `fs2-rabbit-test-support` = project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this published? I should check that out, might be handy in my project :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val amqpClient = "5.7.3"
val logback = "1.2.3"
val monix = "3.0.0"
val zio = "1.0.0-RC12-1"
val zioCats = "2.0.0.0-RC3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should only release ourselves as RC if one of our dependencies is at RC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only for the examples.

@@ -1,2 +1,2 @@
version in ThisBuild := "2.0.0-RC3"
version in ThisBuild := "2.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version in ThisBuild := "2.0.0"
version in ThisBuild := "2.0.0-RC4"

Because of the zio dependency only. Your call

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monix and zio are only pulled by the examples which are not published as a dep.

@gvolpe gvolpe merged commit 0be2ffa into master Sep 17, 2019
@gvolpe gvolpe deleted the release/2.0.0 branch September 17, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants