Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Valkey #863

Open
gvolpe opened this issue Apr 16, 2024 · 4 comments · May be fixed by #864
Open

Migrate to Valkey #863

gvolpe opened this issue Apr 16, 2024 · 4 comments · May be fixed by #864
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gvolpe
Copy link
Member

gvolpe commented Apr 16, 2024

Given the recent news, I would like to move over to Valkey for testing this project. We can continue supporting the latest open source Redis docker images, but won't be supporting newer versions.

@gvolpe gvolpe added enhancement New feature or request help wanted Extra attention is needed labels Apr 16, 2024
@gvolpe gvolpe linked a pull request Apr 16, 2024 that will close this issue
@TobiasRoland
Copy link

👋 @gvolpe Would you expect to move to valkey4cats or sticking with redis4cats for the forseeable future?

@zan-preston
Copy link

It's looking like a fork of jedis is going to be the official java client for valkey. Would there be interest in wrapping that instead of lettuce to ensure compatibility with valkey in the future?

valkey-io/valkey#164 (comment)

@gvolpe
Copy link
Member Author

gvolpe commented Apr 23, 2024

@TobiasRoland a rename is not under consideration at the moment, but we may revisit it in the future.

@zan-preston the Jedis client was never an option, mainly because it used to be blocking, not sure if this is still the case. Anyway, that would be a major rewrite, the two APIs differ so much, especially when it comes to handling transactions and pipelining. I don't think this will be happening any time soon. A new project might have better changes to be honest.

@zan-preston
Copy link

@gvolpe Oh, right that makes sense. I completely forgot when I was quick to ask that jedis was blocking. 😅. Please disregard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants