Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --no-sudo to install.py #19

Merged
merged 1 commit into from Jul 3, 2023
Merged

added --no-sudo to install.py #19

merged 1 commit into from Jul 3, 2023

Conversation

fliem
Copy link

@fliem fliem commented Jul 3, 2023

adds --no-sudo to install.py to make the script run in a docker build env (where the user is already root and has no access to sudo).

./install.py: behaviours should remain unchanged
./install.py --no-sudo: does not invoke commands with sudo

mbaudis
mbaudis approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mbaudis mbaudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - one can always switch to argparse use if more parameters are needed...

@mbaudis mbaudis merged commit 55648d5 into progenetix:main Jul 3, 2023
mbaudis added a commit that referenced this pull request Jul 4, 2023
@mbaudis
1.0.61
7a90140 
* adding `BYCON_MONGO_HOST` environment variable to enable other MongoDB host than
  `localhost` (which remains fallback/default) - thanks @fliem for [#17](#17)
* added `--noo-sudo` to install.py - thanks @fliem for [#19](#19)
* more tweaking of configuration reading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaudis mbaudis mbaudis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fliem @mbaudis