Wrong displayed name for equipped item

[projectdelphai]

Difficulty: Easy

Equipped items are displayed as the item ID instead of the item name. You just need to initialize the item, grab the item name, and then display that instead.

[pthayer3]

Can I tackle this one also as I'm new to java and I feel comfortable going after it?

[shkesar]

Hell yeah!
Just push your changes.

[pthayer3]

I think a solved this, but before I push my changes I am going to try to tweak some other stuff, such as confirmation of performed actions via printing, etc. We also need to add "hands" as an item in the json file, I'll fix that also.

[projectdelphai]

Hands isn't really an item, just a placeholder in the absence of anything else. It should automatically default to hands if there is no item. It shouldn't be an item.

And this may be a pain, but I'm going to have to ask you to update your fork fully. And I mean FULLY. There was a ton of changes with the pull requests and I don't want to have to turn down your pull request because of the recent issues I've been having. It may not be a problem, but just check before making your pull request.

Thanks!

[pthayer3]

The reason why we need to add hands to the items.json file is that I pull the name of the item to display when equipped from the json file. When it gets to hands, it pulls a 'null' because hands doesn't have a name. See below.

public void getStats(){
    Item weapon = new Item(getWeapon());

    System.out.println("Player name: " + getName() +
                        "\nCurrent weapon: " + weapon.getName() +
                        "\nGold: " + player.getGold() +
                        "\nHealth/Max: " + getHealth() + "/" + getHealthMax() +
                        "\nDamage/Armour: " + getDamage() + "/" + getArmour() +
                        "\n" + getName() + "'s level: " + getLevel());
}

We also may want to change the getStats to display the equiped armour while we are at it and therefore the setArmour() method needs to be expanded similar to the setWeapon() method and allow to multiple pieces of armour to be set for different body parts.

I may take a stab at equiping various pieces of armour before I push my changes back.

[projectdelphai]

Can't you also do player.getWeapon()? That should be set to "hands".

[pthayer3]

That would work if the weapon equipped was "hands". When I called player.getWeapon() on the stat line when the player had a shiv equipped it displayed the itemID. I assume the getWeapon() method when called on a weapon that is a class item displays the first value which is the itemID. When "hands" is equipped, it isn't an Item class, it is a string so it just returns hands. I guess that I can put a condition in that if the string is equal to "null", display hands. That would prob get around it without adding "hands" to the json file.

EDIT: I got it working without adding to the json file

[pthayer3]

references #58