Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edge case catch #13

Merged
merged 1 commit into from Mar 1, 2022
Merged

Add edge case catch #13

merged 1 commit into from Mar 1, 2022

Conversation

mikejohnson51
Copy link
Contributor

Previously this:

state = "CA"

county = c("San Luis Obispo", "Santa Barbara",   "Ventura")

fipio::as_fips(county = county, state = state)

Would result in an error.

This has been fixed, a test added, and all tests still pass.

program--
program-- approved these changes Mar 1, 2022
View reviewed changes
Copy link
Owner

@program-- program-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@program-- program-- merged commit de0f068 into program--:master Mar 1, 2022
@mikejohnson51 mikejohnson51 changed the title Add edge cast catch Add edge case catch Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@program-- program-- program-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikejohnson51 @program--