Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn game step programs into functions #19

Closed
programaker opened this issue Jul 24, 2019 · 1 comment
Closed

Turn game step programs into functions #19

programaker opened this issue Jul 24, 2019 · 1 comment
Labels
done Finished task investigation Need to investigate further refactoring Improve things without change behavior

Comments

@programaker
Copy link
Owner

We are using classes to model the Free programs to have the convenience of importing all algebras at the top to make them accessible to the private helper functions, but the program is actually only a function - play().

Try to figure out a more FP design without the classes, if possible and if worths it. Sometimes it’s better to let Scala be Scala 😄
@programaker programaker added investigation Need to investigate further refactoring Improve things without change behavior labels Jul 24, 2019
@programaker programaker mentioned this issue Jul 24, 2019
Closed
@programaker programaker added the in progress Task is being worked on label Oct 1, 2019
programaker pushed a commit that referenced this issue Oct 2, 2019
#19 Quit step is now only functions and ADTs
c2f2e7f
programaker pushed a commit that referenced this issue Oct 2, 2019
#19 ShowIntro step is now only functions and ADTs
2ac027f
programaker pushed a commit that referenced this issue Oct 2, 2019
#19 Better placing types and functions
38ee576
programaker pushed a commit that referenced this issue Oct 2, 2019
#19 SaveGame step converted
1a59579
programaker pushed a commit that referenced this issue Oct 2, 2019
#19 Create character step converted
8aad6ec
programaker added a commit that referenced this issue Oct 2, 2019
@programaker
#19 Explore step converted
b1d9dda
programaker added a commit that referenced this issue Oct 2, 2019
@programaker
#19 Fight step converted
6067948
programaker added a commit that referenced this issue Oct 2, 2019
@programaker
#19 Game converted
70fecd0
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Quit step as function
33deec9
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Save game step as function
4963523
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Game interpreter as function
54cf658
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Game as function
654115c
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Factory methods are also allowed in objects
22df5ec
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Composite interpreters as functions
9e321b9
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Remove functions from Tag object
87897a5
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Line
62a3073
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Separate ask from InteractionOps, as it does not depend on the …
251b3f5 
…InjectK and nor is a Free smart constructor
programaker added a commit that referenced this issue Oct 3, 2019
@programaker
#19 Simplify inject call signature where possible
3357056
@programaker
Copy link
Owner Author

Not worth it to turn everything in stand-alone functions, but a lot of things could and we took many lessons from this issue =D

@programaker programaker added done Finished task and removed in progress Task is being worked on labels Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Finished task investigation Need to investigate further refactoring Improve things without change behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@programaker