fix: rustls 0.23.1, next version of tokio-rustls #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 first which is unreleased." tokio-rustls 0.25.0 is released now, so we can switch back to rustls 0.22. This reverts commit 3003040.
This includes a breaking change to RustlsConfig::from_der; this is because rustls 0.22 no longer has a way to accept a private key in DER Vec<u8> form.
pimeys
force-pushed
the
rustls-0.23
branch
3 times, most recently
from
6b327c5
to
858c9bc
Compare
|
@pimeys Can we merge this now? We are stuck with an older version of rusttls because of this. |
MaxFangX
pushed a commit
to lexe-app/axum-server
that referenced
this pull request
Mar 26, 2024
This patch is from this axum-server draft PR, credit to @eric-seppanen: - programatik29#106 It looks like axum-server will skip directly to 0.23, so this patch can be removed then. programatik29#112
|
@diptanu you can integrate the changes from this PR into your own project with a patch like so: [dependencies]
axum-server = "=0.6.0"
[patch.crates-io]
axum-server = { git = "https://github.com/grafbase/axum-server", branch = "rustls-0.23" } |
|
@MaxFangX Thanks! It would be great if this PR was merged in because SSL and being able to use latest version of the rust-tls library would be great. |
|
+1 on getting this merged. |
|
In the meantime @pimeys will you update this PR? @programatik29 can we get this merged somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
We can merge this only when the next version of tokio-rustls is out. I'm just opening it up already because we upgraded our whole project and need this dependency. Having this PR in our Cargo.toml so we can review and step back to crates.io when the dependency issues in the ecosystem are all merged and published.
Supersedes: #106