Migration to Hyper 1.0 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlip9
added a commit
to lexe-app/axum-server
that referenced
this pull request
May 18, 2024
The hyper v1 migration PR (programatik29#93) accidentally (?) removed the call to `serve_future.graceful_shutdown()`, which prevents the server from shutting down until all client _connections_ close on their own (or we hit the hard shutdown timeout). In practice, this meant we always hit the hard shutdown timeout, since most clients use connection pools with connection keepalive. With this change, graceful shutdown will now correctly stop handling any new requests after it's triggered, while letting existing requests complete (within the timeout of course). Fixes programatik29#114
phlip9
added a commit
to lexe-app/axum-server
that referenced
this pull request
May 20, 2024
The hyper v1 migration PR (programatik29#93) accidentally (?) removed the call to `serve_future.graceful_shutdown()`, which prevents the server from shutting down until all client _connections_ close on their own (or we hit the hard shutdown timeout). In practice, this meant we always hit the hard shutdown timeout, since most clients use connection pools with connection keepalive. With this change, graceful shutdown will now correctly stop handling any new requests after it's triggered, while letting existing requests complete (within the timeout of course). Fixes programatik29#114
phlip9
added a commit
to lexe-app/axum-server
that referenced
this pull request
May 20, 2024
The hyper v1 migration PR (programatik29#93) accidentally (?) removed the call to `serve_future.graceful_shutdown()`, which prevents the server from shutting down until all client _connections_ close on their own (or we hit the hard shutdown timeout). In practice, this meant we always hit the hard shutdown timeout, since most clients use connection pools with connection keepalive. With this change, graceful shutdown will now correctly stop handling any new requests after it's triggered, while letting existing requests complete (within the timeout of course). Fixes programatik29#114
phlip9
added a commit
to lexe-app/axum-server
that referenced
this pull request
May 20, 2024
The hyper v1 migration PR (programatik29#93) accidentally (?) removed the call to `serve_future.graceful_shutdown()`, which prevents the server from shutting down until all client _connections_ close on their own (or we hit the hard shutdown timeout). In practice, this meant we always hit the hard shutdown timeout, since most clients use connection pools with connection keepalive. With this change, graceful shutdown will now correctly stop handling any new requests after it's triggered, while letting existing requests complete (within the timeout of course). Fixes programatik29#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.