Static asset file server wrapper #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
unai-programmfabrik
commented
Jul 6, 2020
unai-programmfabrik
commented
- Added wrapper handler for static serve files in order to apply some modifications to response if possible
- Added content-length skip modification to static serve files
- Documented the query string parameter in request url for static file without content-length
… modifications to response if possible - Added content-length skip modification to static serve files - Documented the query string parameter in request url for static file without content-length
martinrode
requested changes
Jul 6, 2020
README.md
Outdated
Comment on lines
1598
to
1600
| #### Skip Content-Length header | ||
|
|
||
| For some tests, you may not want the Content-Length header to be sent alongside the asset |
There was a problem hiding this comment.
Name this "No Content-Length" header.
http_server.go
Outdated
Comment on lines
72
to
74
| skipContentLengthHeader := qs.Get("skip-content-length") | ||
| if skipContentLengthHeader == "1" || skipContentLengthHeader == "true" { | ||
| w.Header().Set("Content-Encoding", "identity") |
There was a problem hiding this comment.
Use "no-content-length".
…ngth - Updated docs also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.