New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only capitalize exported/environment variable names #13
Comments
I do this too. Great suggestions. |
You didn't do it in Dokku 😜 |
Omg, I don't think I did any of this in Dokku. |
I'm working up to a rewrite/re-architecting of Dokku if you haven't noticed. Starting inside out. |
Have you checked out https://github.com/plushu/plusku ? It's been feature-parity with Dokku for a while (not including the seamless-failover patch, and the not-building-or-running-apps-as-root thing) with a number of little improvements here and there (off the top of my head: the entire Plushu plugin architecture, nginx runs in a container, configurable domains, tls certificates are only used when they match a domain, and I'm half-finished a system for adding addons like redis and mongo). I even did https://github.com/plushu/plushu-dokku as an alternative that replicates Dokku's interface in the places where I took a different approach for Plusku (like implicitly creating apps when pushing to a new name, which Plushu does not do). |
Maybe you can give me a tour of it sometime over Skype. On Tue, Jan 6, 2015 at 4:39 PM, Stuart P. Bentley notifications@github.com
Jeff Lindsay |
Sure, the code has a kind of unusual architecture since nigh everything is based on the bag of plugins that are installed hitting wildcards. I spent a couple hours the other day just flowcharting how apps get built: https://drive.google.com/file/d/0Bw6BK7O9rKIDT0JYMmJYREZWNWM/view?usp=sharing - I got to the "deploy-app" step when I realized I kind of need to refactor it (plushu/plushu-deploy-app-local-container#9) before I go documenting the way it works because I don't want outdated documentation describing the wrong way I used to do it. So yeah, tl;dr rapidly changing and incomplete docs, because prototypes. I'll see if I can clear some time later this week to show you around the current structure. |
Email me and we can set up a time to swap notes. On Tue, Jan 6, 2015 at 4:57 PM, Stuart P. Bentley notifications@github.com
Jeff Lindsay |
All the issues I'm filing across all the plugins are basically the best documentation / notes I have on it as it develops: I have https://waffle.io/plushu/plushu pinned next to https://ide.c9.io/stuartpb/plushu whenever I sit down to work on this stuff. |
This is one of the stylistic rules I'm using for Plushu, and it's working out pretty well: only use
ALL_CAPS_SNAKE_CASE
when you're going to be getting a variable from the environment, or when you're going to export it to the environment. Names for script-local variables that will only appear in subshells should besmall_caps_snake_case
.The text was updated successfully, but these errors were encountered: