Mention 'set -u' and ${arg:?message} #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes progrium#29. Closes progrium#37.
ernstki
force-pushed
the
29-37-set-dash-u
branch
from
5bcd88a
to
aeb6be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make this as uncontentious as possible, with
set -uo pipefailbeing the "do this 100% of the time by default" advice andset -ebeing the "but also consider this" choice.The
set -upart should not be controversial. It'suse strictfor Bash, which would be the default in e.g. Perl and JavaScript if not for concerns of backward compatibility.But if you feel very, very strongly about having all three of them together (
set -euo pipefail), I am happy to defer to your judgment there and amend this PR.Closes #29 and #37.