Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the OpenWRT/LEDE snapshots (fixes #29) #30

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

typekpb
Copy link
Contributor

@typekpb typekpb commented Oct 5, 2018

Provides a fix for #29 as the snapshot links don't seem to work any more => using the latest released ones.

@jackwilsdon
Copy link
Collaborator

So it appears that OpenWRT and the LEDE project merged at the start of this year and the downloads have been moved to http://downloads.lede-project.org/. We can still use the trunk snapshot by changing the URLs to start with http://downloads.lede-project.org/snapshots/packages/x86_64/ instead if that is more appropriate than using a fixed version.

@progrium
Copy link
Owner

progrium commented Oct 6, 2018

I'll merge whatever. Anybody want to be maintainer?

@jackwilsdon
Copy link
Collaborator

I wouldn't mind if @typekpb doesn't want to 😁

Just noticed that the packages link in the README needs updating too @typekpb.

@progrium
Copy link
Owner

progrium commented Oct 6, 2018

You've been invited as a collaborator. Merge away!

@typekpb
Copy link
Contributor Author

typekpb commented Oct 6, 2018

@progrium @jackwilsdon updates to suggested snapshots, see the last commit

@progrium I just went by, so beeing a mainterner makes no sense from my point of view. Anyway @jackwilsdon sounds like the motivated and skilled candidate :)

@typekpb typekpb changed the title Using 18.06 packages (fixes #29) Using the OpenWRT/LEDE snapshots (fixes #29) Oct 6, 2018
@udkumar
Copy link

udkumar commented Oct 9, 2018

When we can update the docker image as well for the above pull request?

@progrium
Copy link
Owner

progrium commented Oct 9, 2018

...when it's merged?

@udkumar
Copy link

udkumar commented Oct 9, 2018

@progrium
PR #30 generated by @typekpb. My question "busybox" has the docker image than for this update you should rebuild the docker image as well.

I am not seeing docker image version for each build, so it is hard to manage version if anyone using same docker image.

I raised #29 and that is the package directory changed from OpenWRT.

@progrium
Copy link
Owner

progrium commented Oct 9, 2018

It will update automatically afaik when master branch changes. If you want one with version tags you'll have to join as a maintainer and make that happen or use another image. Sorry if I'm misunderstanding you.

@udkumar
Copy link

udkumar commented Oct 9, 2018

Thanks!
I will be happy to maintain the busybox docker image.
BDW my docker hub username is "umitoit"

@progrium
Copy link
Owner

progrium commented Oct 9, 2018

I meant the github project. If you have specific changes to make on Docker Hub, lay them out clearly in an issue.

@udkumar
Copy link

udkumar commented Oct 10, 2018

Hello @progrium
Yes! Its ok for me

You can add me as maintainer.

@udkumar
Copy link

udkumar commented Oct 10, 2018

@typekpb @progrium @jackwilsdon
When I can expect this fix will add in master?

@typekpb
Copy link
Contributor Author

typekpb commented Oct 10, 2018 via email

@udkumar
Copy link

udkumar commented Oct 10, 2018

@progrium
I really appreciate if you do needfull.

@progrium progrium merged commit 3f8b06c into progrium:master Oct 10, 2018
@udkumar
Copy link

udkumar commented Oct 10, 2018

@progrium thanks for merging the fix to master.

Something went wrong with building with docker image.
I am getting build failed, Please check from your side.

@udkumar
Copy link

udkumar commented Oct 10, 2018

@typekpb
here is the issue with your fix while building docker image:

@jackwilsdon
Copy link
Collaborator

I've just pushed 6b6bf03 which fixes that @udkumar, it has now built successfully and is available under the latest tag.

@udkumar
Copy link

udkumar commented Oct 10, 2018

@jackwilsdon Thanks!

@udkumar
Copy link

udkumar commented Oct 11, 2018

@typekpb @jackwilsdon
Still, I am getting the same error...

=========================
Step 3/6 : RUN opkg-install libseccomp ca-certificates
---> Running in d10c49dfc7be
wget: server returned error: HTTP/1.1 404 Not Found
wget: server returned error: HTTP/1.1 404 Not Found
Downloading http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/base/Packages.gz.
Downloading http://downloads.openwrt.org/snapshots/trunk/x86/64/packages/packages/Packages.gz.
Collected errors:

I raised the issue fro the same error!

I used the --no-cache flag as well with my build

@jackwilsdon
Copy link
Collaborator

Have you downloaded the new latest image?

docker pull progrium/busybox:latest

@udkumar
Copy link

udkumar commented Oct 11, 2018

@jackwilsdon
Here is my Dockerfile:

FROM progrium/busybox
RUN opkg-install libseccomp ca-certificates

--------- And I tried below as well -------------
FROM progrium/busybox:latest
RUN opkg-install libseccomp ca-certificates

@jackwilsdon
Copy link
Collaborator

I tried your Dockerfile and it works fine. The image on Docker Hub is up to date and working, but your machine will already have a downloaded version of progrium/busybox:latest from before the issue was fixed. Have you tried running the command I posted above?

@udkumar
Copy link

udkumar commented Oct 12, 2018

@jackwilsdon
Thanks a ton...
I deleted all cache and rebuild the image..... No Error getting now.........

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants