Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dokku errors if bin/release script not present #1112

Closed
dbp opened this issue Apr 15, 2015 · 10 comments
Closed

Dokku errors if bin/release script not present #1112

dbp opened this issue Apr 15, 2015 · 10 comments

Comments

@dbp
Copy link

dbp commented Apr 15, 2015

According to the documentation, the bin/release script is optional, and should only be run if present. But dokku errors out if it's not present. The error looks like:

remote: /build/compile.sh: line 73: /tmp/buildpacks/custom/bin/release: No such file or directory

See mietek/haskell-on-heroku#51 for more details.

@josegonzalez
Copy link
Member

@progrium

@michaelshobbs
Copy link
Member

@dbp i definitely see this issue using the latest buildstep release. However, master is now using herokuish. Can you build buildstep from master and see if the issue persists?

i.e.

docker rmi progrium/buildstep
BUILD_STACK=true make -e stack

You'll need to remove any containers that rely on progrium/buildstep first.

EDIT: I'm willing to bet this is fixed now, in fact. See here: https://github.com/gliderlabs/herokuish/blob/f2f974ee2645bb418d35d5cd327b4f86b4f791f5/include/buildpack.bash#L105-L107

@dbp
Copy link
Author

dbp commented Apr 16, 2015

@michaelshobbs That looks like it is fixed - thanks for figuring that out! Do you know when that'll get out as a release? I have a fork of the mentioned buildpack that has a dummy bin/release file, but it'd be nice not to have that.

@michaelshobbs
Copy link
Member

@progrium can we get a buildstep release cut?

@seanhess
Copy link

I'm interested in this as well!

@progrium
Copy link
Contributor

I thought a PR was being made to use Herokuish directly.

On Thu, Apr 23, 2015 at 9:57 PM, Sean Hess notifications@github.com wrote:

I'm interested in this as well!


Reply to this email directly or view it on GitHub
#1112 (comment).

Jeff Lindsay
http://progrium.com

@josegonzalez
Copy link
Member

@progrium tests fail and we'd want to release against a versioned build to ease our own debugging.

@michaelshobbs
Copy link
Member

@progrium @josegonzalez
where did we end up on the whole versioned herokish build thing?

@mietek
Copy link

mietek commented May 25, 2015

What’s the status of this issue?

@josegonzalez
Copy link
Member

We've switched to herokuish, so this can be closed. Please comment if you still see this as an issue in the latest version of dokku :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants