-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we persist nested dind data on user's env? #42
Comments
You shouldn't have to recreate the DinD environment instance. But in any case, I'm not sure what you mean by "over here too". You mean upstream in this repo? What do the expose flags give you? |
But what if we want / need to upgrade the DinD image to a new Docker version or switch over to some other image based on another distro? As of current master (and based on my current Docker knowledge) I think that would require us to recreate things from scratch right? For sure we can figure out a way of grabbing the volume and reusing it for a new DinD instance but by keeping it on a well known place I believe will make things easier 😄
Right on! I'm hacking away on a separate repo and I'm holding back from sending PRs this way to avoid the noise as I saw on your video that you are putting up some cool things in Go. I just want to make sure I'm relying on appropriate behavior that is likely to land on Envy's core to avoid having trouble upgrading my environments on the future.
With that I was able to attach a simple nginx container on a I know you are planning to use iptables for port redirection but I still need to be able to access the web apps from port |
Good point on upgrading DinD. I just don't expect it should be restarted Glad you're exploring more and sending back feedback like this. Okay cool, I just wanted to make sure you didn't find something iptables On Tue, Jul 14, 2015 at 7:31 PM, Fabio Rehm notifications@github.com
Jeff Lindsay |
@fgrehm I actually just added support for multiple ports on envy-proxy. just pass in Sounds like you did something similar to envy-proxy, which just uses nginx to proxy to the dind and uses docker-gen to auto gen the nginx conf |
@jgallen23 cool! I'll give it another spin and will see if I can be of any help over there 😄 🍻 |
I took a stab at implementing the support for exposing ports for web servers on my fork and the way I made it work was to recreate the nested docker instance passing in the appropriate
--expose
flags.In order for that to work, I had to be able to recreate the docker instance without losing the data I already had there, so I ended up passing in
--volume "$HOST_ROOT/users/$USER/docker/$ENVIRON:/var/lib/docker"
to the environment container and was wondering if it would make sense to have this over here too.WDYT?
The text was updated successfully, but these errors were encountered: