Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma upvotes for users/nicks; fixing the delimiters #1495

Open
prdes opened this issue Nov 13, 2021 · 2 comments
Open

Karma upvotes for users/nicks; fixing the delimiters #1495

prdes opened this issue Nov 13, 2021 · 2 comments

Comments

@prdes
Copy link
Contributor

prdes commented Nov 13, 2021

According to the current setup, when the following nick patterns are upvoted (++),

  1. nick++
  2. nick ++
  3. nick: ++
  4. nick, ++

The increment doesn't strip the space char, nor the various other chars that clients seem to have appended to autocompleted nicks as defaults, resulting in every pattern having 1 vote.

@prdes
Copy link
Contributor Author

prdes commented Nov 16, 2021

#1496
Now this is the concept borrowed from the karma implementation in Bitbot in terms of the regex and the reverse karma (which isn't particularly necessary imo) but the parenthesis version is interesting.

Issue is that it is only using ++ and -- as the inc and dec chars respectively.

P.S. Naturally there are tests to be written

@prdes
Copy link
Contributor Author

prdes commented Nov 16, 2021

I'll just use %s for the inc and dec variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants